Repository navigation
A Triage run discards its whole analysis over a questionnaire or field-shape mismatch #2019
Description
This was generated by AI during triage.
What happened
A Triage run whose session wrote a full recommendation fails as a whole because one field is slightly off. Five runs failed this way on 2026-11-10 (thirdshift 0.27.2, Claude Code, across three private repositories):
- 4 runs:
the Triage questionnaire is required only for needs-info or ready-for-human issues: <issue title> - 1 run:
the Triage recommendation is not valid recommendation JSON: unknown field 'comments', expected one of 'title', 'body', 'category', 'state', 'confirmation_blocked', 'questionnaire'. The session nestedcommentsinside an issue object instead of at the top level.
Where
parse_recommendation in src/triage.rs:~210:
ensure!requires a questionnaire exactly when the issue's final state isneeds-infoorready-for-human, and forbids one otherwise.serderejects unknown fields.
Either mismatch discards the investigation and every proposed issue.
Expected
A recoverable shape error doesn't throw the analysis away. Possible approaches:
- drop a questionnaire that isn't needed;
- downgrade to
needs-triagewhen a needed questionnaire is missing; - give the session one Repair turn quoting the error.
Then a failed run is kept for a real problem only.
Activity
JacobStephens2 commentedon Nov 11, 2026
Agent Brief
Confirmed on selected Base commit de91156. Keep #2019 as one standalone Ticket: give an invalid Triage recommendation one bounded correction turn before failing.
Diagnosis and evidence
Required behavior
Validation
Add regressions for unnecessary and missing questionnaires, misplaced comments, and a recommendation containing both valid and malformed issue entries. Verify successful correction preserves the complete investigation and all intended issues/comments; repeated malformed output stops after one correction; no publication happens before validation; recommendation-only remains mutation-free; and existing-issue cardinality and Agent Brief requirements still hold. Cover Report and existing-issue modes. Update prompt/documentation sources and regenerate derived pages if their contracts change. Run scripts/affected-tests main.
Investigation results
Both focused existing tests passed: cargo test --test triage_run questionnaires_are_required_only_for_issues_waiting_for_a_person -- --exact --nocapture, and cargo test --test triage_issue recommend_only_rejects_invalid_recommendations_without_mutation -- --exact --nocapture. The first exercises 16 mismatch cases. No source or Git-history changes were made.