Spec review before the Spec PR is ready #142

Parent

#139

What to build

The Spec review: once every Ticket has landed on the Spec branch, and before the Spec PR is marked ready, thirdshift starts an agent session in a worktree on the Spec branch.

Its prompt is new and shaped like the Continuation prompt, over the existing Factory skills (no new skill):

• /thirdshift:code-review of the Spec branch, with the Base branch as the fixed point and the Spec issue as the spec
• fix the Standards and Spec findings it agrees with, using /thirdshift:tdd where it fits, and commit
• push the Spec branch and update the Spec PR through /thirdshift:pr, with a body covering the whole Spec, an "Unaddressed findings" section, and Closes #<spec>

thirdshift then checks the Spec PR exists and is open, and marks it ready. The session gets a log under the Spec's name like any session, and the prompt ends with the headless instructions every prompt ends with.

Acceptance criteria

• After the last Ticket lands, exactly one Spec review session starts, in a worktree on the Spec branch
• Its prompt names the Spec's Issue URL and the Base branch as the review's fixed point, and asks for an "Unaddressed findings" section and Closes #<spec>
• Commits the Spec review makes are on the Spec branch on origin
• The Spec PR is marked ready only after the Spec review ends
• A Spec review session that fails ends the Spec run with a non-zero exit, without marking the Spec PR ready
• The Spec review prompt appears on the Prompts and skills page, whose golden-file test keeps it up to date

Blocked by

• Tracer bullet: a linear Spec run to a ready Spec PR #141