Skip to content

error about issue not being able to be closed yet it was #122

Closed as not planned

Description

@JacobStephens2

thirdshift: warning: could not close issue #114, so if it is still open, close it by hand: gh issue close 114 --repo JacobStephens2/thirdshift --comment 'Closed by #121, merged into main by a thirdshift Merge run.'
thirdshift: cleaning up the worktree and local branch issue-114
thirdshift: PR #121 is merged
#121
jacob@tracewake:/repos/thirdshift$ gh issue close 114 --repo JacobStephens2/thirdshift --comment 'Closed by #121, merged into main by a thirdshift Merge run.'
! Issue #114 (--email sends a Run notification whenever a Run ends) is already closed
jacob@tracewake:
/repos/thirdshift$

Activity

  1. JacobStephens2 commented on Sep 30, 2026

    @JacobStephens2
    OwnerAuthor

    This was generated by AI during triage.

    Already fixed. The warning was wrong: GitHub closed #114 itself a moment after #121 merged, because #121's body says Closes #114.

    Before closing the issue, thirdshift v0.3.0 asked gh pr view --json closingIssuesReferences whether the merge would close it. gh 2.45 doesn't support that field, so the call failed and thirdshift reported the failure as "could not close issue #114".

    #181 reported the same failure, and #186 (commit f2ab46a) fixed it. After a merge, thirdshift now checks only the issue's state and closes the issue if it is still open (close_unless_closed in src/run.rs). The fix shipped in v0.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingwontfixThis will not be worked on

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions