Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SELECT CAST(ROW(1) AS ROW(x BIGINT))parses successfully, buttoString()andStatementDeParserboth dereference a null scalar type instead of rendering the one-element row definition.Treat any nonempty
columnDefinitionslist as a row target in both serializers. Add a regression that checks the parsed field metadata and independently exercises both serialization paths, plus aTRY_CASTround trip. Existing multi-field and scalar cast coverage remains in the same test class.Validation: the new regression fails on unmodified master with both NPEs; the same query also fails with the released 5.4 artifact.
mvn verifycompleted the full suite (9,525 tests, 0 failures/errors, 25 skipped), PMD and Checkstyle. The subsequentspotless:checkrequested import sorting in the two touched production files;mvn spotless:apply spotless:checkthen passed.Fixes #2756.