Skip to content

DoubleValue.setValue does not set stringValue #2008

Closed

Description

@Qnzvna

When using setValue on DoubleValue object only the value is set. The setter does not change stringValue which is then used in toString method.

Following test would fail:

    @Test
    public void shouldSetStringValue() {
        final DoubleValue doubleValue = new DoubleValue("42");

        doubleValue.setValue(43D);

        assertEquals(43D, doubleValue.getValue());
        assertEquals("43.0", doubleValue.toString());
    }

Activity

  1. manticore-projects commented on May 19, 2024

    @manticore-projects
    Contributor

    Thank you for reporting, I would fix this asap.

  2. Qnzvna commented on May 19, 2024

    @Qnzvna
    ContributorAuthor

    Thanks, I've opened PR -> #2009, so you can review.

  3. Qnzvna commented on May 19, 2024

    @Qnzvna
    ContributorAuthor

    @manticore-projects Thanks for reviewing. When you will be able to release a new version to maven ?

  4. manticore-projects commented on May 20, 2024

    @manticore-projects
    Contributor

    Greetings, we don't have any exact date for a new release 5.0 but my take is: before End of June.
    Please note that as a matter of fact, JSQLParser has become a rolling-release where every last snapshot is deemed to be the latest greatest version and "stable release" does not bear any actual advantage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions