Skip to content

use interface in ColumnDefinition #1367

Closed
#1778
Closed
use interface in ColumnDefinition#1367
#1778

Description

@sixinli
sixinli
opened on Oct 12, 2021

it seems like since https://github.com/JSQLParser/JSqlParser/pull/1274/files#diff-7a533138e54adbf0baac5356d4b7d4a6d192300199ef50eede004f706fd35de3R104 ColumnDefinition accepts ExpressionVisitorAdapter

JSqlParser/src/main/java/net/sf/jsqlparser/statement/create/table/ColumnDefinition.java

Lines 104 to 106 in c89cf21

public void accept(ExpressionVisitorAdapter expressionVisitor) {
expressionVisitor.visit(this);
}

is it possible to have it take one of the interfaces instead?

(just noticed also, they seem to be referencing each other, ExpressionVisitorAdapter#visit calls ColumnDefinition#accept)

Activity

  1. manticore-projects commented on May 22, 2023

    @manticore-projects
    manticore-projects
    on May 22, 2023
    Contributor

    Greetings,

    this seems to have been cleaned up with revision commit 288b177 in PR #1778 already.

  2. manticore-projects
    closed this as completedon May 22, 2023
  3. manticore-projects
    reopened this on May 22, 2023
  4. manticore-projects
    closed this as completedin #1778on Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions