Repository navigation
make: a linker cfg edit relinks the PRG (#305) - #306
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… wording (#305) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #305
Fix
build/flags.stampnow includes the selected cfg's sha256 (CFG_SHA256). A cfg content change takes the existing parse-time path: stamp rewritten, objects and all four link outputs deleted. Content-based, so the macOS make 3.81 1-second mtime trap does not apply. Edit is two local spots in the stamp block (a variable and one body line), clear of the wildcard lines. Over-invalidation: a cfg edit also rebuilds objects (~0.4 s), the same as any flag change.Red-green
New
test_cfg_edit_relinks_every_link_output(tools/test_build_flags_stamp.py): per cfg, builds in a farm with a private cfg copy, checks an untouched cfg relinks nothing, appends a comment, asserts ld65 runs, PRG/labels/map/dbg all rewritten, PRG sha unchanged. Profiles: uci.cfg (REU and onchip), uci-onchip.cfg (comb COLD_BANK=0), uci-onchip-cold.cfg (comb), uci-m3.cfg. ip65 is not in the test (needs ip65 libs); checked by hand in the worktree, stale before and relinked after.python3 tools/test_build_flags_stamp.pyPASSED, 18/18 (all pre-existing cases still pass, including the dry-run and no-op-rebuild ones).PRG bytes unchanged
make packageunder LANG=en_US.UTF-8, before and after the Makefile change, identical:No hardware run: the PRGs are byte-identical, so there is nothing new for a device to execute.
CLAUDE.md: one clause in the flags.stamp paragraph.
Amendment (review)
$(PRG): $(PRG_DEPS) $(CFG), no hash): test_cfg_edit_relinks_every_link_output and the new ip65 test FAIL; with the fix 19/19 pass.🤖 Generated with Claude Code