Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,9 @@ stdout.
Also the only completeness
oracle: `tools/http_body_checks.py`
(exit 78 = inconclusive, #210)
rig_trust_store.py / rig_trust_policy.py — TRUST.A/B on `/<vol>/c64https-test`
via harness `storage_*`; no
writable volume = exit 2
rig_https_bad_finished.py — forged server Finished must abort
(`FINISHED_MODE=good` control first)
bench_ecdsa_u64e.py — verify wall-clock sweeps
Expand Down Expand Up @@ -531,8 +534,9 @@ engineering-notes.
'Q'. Probe DHCP with a fast-boot (onchip) image, never comb.
- **writemem exhaustion wedge** (fw 3.14d, GideonZ/1541ultimate#686):
each REST `writemem` leaks a `/Temp` file; after ~15 loads REST and the
UCI bridge wedge together. `tools/uci/_temp_gc.py` FTP-deletes them;
wired into the live/wiki rigs.
UCI bridge wedge together. c64-test-harness handles it: any default
`Ultimate64Client` on a leak-prone device sweeps `/Temp` while this
process holds the DeviceLock (our `_temp_gc.py` is retired).
- The U64E is a shared device: trust `DeviceLock`, never kill other
sessions' processes or force-reboot it.

Expand Down
9 changes: 5 additions & 4 deletions docs/engineering-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -1138,9 +1138,9 @@ The scripts:
(`HTTPS_TARGET=github.com`, DMA-fed to the
PRG so any build works). Pass criteria are
C64-side only (sentinel + `http_status=200`).
Runs the `/Temp` GC (`_temp_gc.py`) after
enable_uci — see the writemem-wedge note in
"End-to-end HTTPS status". Comb
`/Temp` hygiene is the harness's (its
`Ultimate64Client`, under the DeviceLock;
the old `_temp_gc.py` is retired). Comb
`C64_INIT_WAIT=75` is auto-detected from
labels.txt. Keep `DEBUG_CAPTURE=0` here.
- `rig_https_local.py` — HTTPS e2e scaffolding against a local TLS 1.3
Expand Down Expand Up @@ -1312,7 +1312,8 @@ and then REST *and* the UCI bridge wedge together — ping alive, REST
refuses instantly, C64 parks mid-transfer. Power cycle fixes; upstream
GideonZ/1541ultimate#686 (merged, unreleased). Mitigated by
`tools/uci/_temp_gc.py` (FTP-deletes managed `temp<HEX>` files, keep
youngest 2; wired into the live/wiki rigs). Budget PRG loads per session;
youngest 2; wired into the live/wiki rigs; since retired — the harness's
`Ultimate64Client` sweeps `/Temp` under the DeviceLock). Budget PRG loads per session;
`readmem` is not implicated.


Expand Down
1 change: 1 addition & 0 deletions pytest.ini
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ testpaths =
tools/test_runner_coverage.py
tools/test_skip_policy.py
tools/test_trust_bundle_unit.py
tools/test_trust_rig_storage.py
tools/test_trust_store_format.py
tools/test_uci_abort_recovery.py
tools/test_uci_data_acc.py
Expand Down
2 changes: 1 addition & 1 deletion tools/_skip_policy.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def _opted_out(opt_out_env: Optional[str]) -> bool:
Bare truthiness would make ``C64_ALLOW_SKIP=0`` and
``C64_ALLOW_SKIP=false`` ENABLE the opt-out -- someone setting 0 to shut
the escape hatch would silently disable the whole policy. Every other
gate in this repo (``C64_SKIP_BUILD``, ``C64_SKIP_TEMP_GC``,
gate in this repo (``C64_SKIP_BUILD``,
``C64_NET_TESTS_OPTIONAL``, ``VICE_HTTPS_OK_TO_RUN``) compares to the
literal "1"; this one does too. Surrounding whitespace is tolerated
because a shell export can carry it; nothing else is.
Expand Down
6 changes: 3 additions & 3 deletions tools/test_rig_scratch.py
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,9 @@ def at_lock(lock, **k):
patch("ACCEPT_TIMEOUT", 0.2)
# rig_https_wiki: trampoline mode is the one that allocates.
patch("MENU_MODE", False)
# rig_trust_store: the fake PRG carries no store path to read.
if hasattr(mod, "TEST_DIR"):
patch("image_store_path", lambda prg, L: mod.TEST_DIR + "/TRUST.")
# the trust rigs: the fake PRG carries no store path to read.
if hasattr(mod, "image_store_path"):
patch("image_store_path", lambda prg, L: "/USB1/c64https-test/TRUST.")
if orig_bind is not None:
patch("_try_bind", lambda ip, port: orig_bind("127.0.0.1", 0))
try:
Expand Down
Loading