Repository navigation
fix: include language mount paths in documentation URLs - #19
Open
Hanabi9248 wants to merge 1 commit into
Open
Hanabi9248 wants to merge 1 commit into
Hanabi9248 wants to merge 1 commit into
Conversation
Set each Antora site URL to its published /en or /cn mount so canonical and sitemap URLs identify the corresponding language site. Validation: real Antora 3.1.7 HTML/URL fixture with current UI ZIPs; baseline 5 failures and 2 controls pass, candidate 7 checks pass. PDF/search extensions, full remote content and browser deployment unrun. Signed-off-by: Hanabi9248 <hanabi210902@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build scripts publish English and Chinese documentation under separate /en and /cn directories, but both playbooks set site.url to the domain root. Antora consequently generates canonical and sitemap URLs without the language mount, and corresponding English and Chinese pages identify the same canonical URL.
Set each playbook's site URL to its language mount. This also supplies the intended site pathname for navigation and redirects; output directories and relative page paths remain unchanged.
Validation with actual Antora 3.1.7, a local two-language Git content fixture and the current official UI ZIPs: baseline has five failing URL checks and two output/link controls passing; candidate passes all seven, without skips. Generated canonical URLs and sitemap entries include their language, and no nested en/en or cn/cn output is introduced. Runs used one CPU, 768 MiB aggregate memory, sixteen processes and private TMP.
An additional candidate integration run enabled the real Lunr extension with the configured EN and CN languages, generated both search indexes using the current UI ZIPs, loaded them with the real Lunr engine and queried the fixture Welcome page. Both result links resolve under the appropriate /en or /cn mount. This checks generated indexes and link resolution; it does not exercise browser interaction or Chinese-language query quality.
The fixture uses local content/bundles and a fixture start page, disables network refresh and omits PDF. Full remote content generation, PDF, browser behavior and live deployment were not run. The live language-page fetches were unavailable and are not evidence of a production HTTP error.