Repository navigation
Conversation
Assisted-by: OpenAI:GPT-6 Percentage of AI-generated code: 100%
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Thanks for contributing to IvorySQL! |
Fixes #3289.
The streaming recovery regression fails in a checkout whose absolute path contains Chinese characters. When
copyencoding.sqlchanges the client encoding to LATIN1 or EUC_JP, psql interpolates the UTF-8 build path into SQL using the new encoding. File lookup and parsing then fail before the intended COPY encoding checks can run.Change into the regression output directory while the connection still uses UTF-8. Use psql's
\copywith relative client-side filenames for the three calls made under a different client encoding. The server still performs the CSV and JSON data conversion. Existing server-file coverage remains in the explicit ENCODING cases, and the JSON byte checks still verify the LATIN1 output.On macOS arm64 with master 475ab19 and a Chinese checkout path:
pg_regress copyencodingfails with file-not-found and invalid multibyte character errors. The updated test passes.make -C src/test/recovery installcheck PROVE_TESTS=t/027_stream_regress.plpasses all 11 TAP assertions, including the SQL regression run.git diff --checkpasses.Follow-up local verification used a clean macOS build with libxslt enabled. The world run passed all 246 core SQL regressions, including
copyencoding, along with recovery, subscription, and the contrib tests includingxml2. The run then stopped because the pg_upgrade test extension was absent. After compiling that fixture, pg_upgrade passed all 127 assertions. The remaining psql prompt test timed out without readline. After rebuilding psql with readline, all 251 psql TAP assertions and all 360 scripts TAP assertions passed. The remaining world targets were verified in separate runs. The two files in this PR match the tested files byte for byte.The local macOS build used the existing libpq build dependency from #2989 for both test versions. The two test files are the full scope of this PR.
Assisted-by: OpenAI:GPT-6
Percentage of AI-generated code: 100%
Summary by CodeRabbit