Repository navigation
fix(SDK-748): forward appAlreadyRunning on Android push open - #912
Merged
jferrao-itrbl merged 6 commits intoOct 6, 2026
Merged
jferrao-itrbl merged 6 commits into
jferrao-itrbl merged 6 commits into
Conversation
The bridge accepted the flag but dropped it before IterableApi. Call the five-argument trackPushOpen overload so campaigns see the real value.
jferrao-itrbl
marked this pull request as draft
October 1, 2026 19:53
|
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. 🚦 See full report on Qlty Cloud »🛟 Help
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
Add RNIterableInternal unit tests against the five-argument trackPushOpen overload, wire testDebugUnitTest in CI, and implement embedded sync handler stubs required to compile against iterableapi 3.10.1.
Keep compile-only stubs for IterableEmbeddedUpdateHandler without emitting events outside SDK-748 scope; JS wiring remains SDK-749.
…rward-app-already-running Keep parity embedded sync handler emissions; SDK-748 push-open forwarding unchanged.
jferrao-itrbl
marked this pull request as ready for review
October 5, 2026 09:12
rtlsilva
approved these changes
Oct 6, 2026
rtlsilva
left a comment
rtlsilva
left a comment
There was a problem hiding this comment.
Approving with minor comments. Address or merge at will.
Scope push-open fix to trackPushOpenWithCampaignId and call the package script from the Android CI job.
jferrao-itrbl
merged commit Oct 6, 2026
8d2ec19
into
feature/SDK-548-feature-parity
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
🎟️ Jira Ticket: SDK-748
📖 Description
Iterable.trackPushOpenWithCampaignIdalready passesappAlreadyRunningfrom JS, and the TurboModule accepts it on Android, butRNIterableInternalcalled the four-argumenttrackPushOpenoverload that hardcodesfalse.This PR threads the boolean through
RNIterableAPIModuleImpl→RNIterableInternal→IterableApi.trackPushOpen(..., appAlreadyRunning, dataFields). No JS, iOS, or TurboModule contract changes.🧪 How to test?
yarn test --coverage(existing tests assert the flag is passed to the native module from JS).Iterable.trackPushOpenWithCampaignId(..., appAlreadyRunning: true)and confirm the native SDK receivestrue(debugger breakpoint onRNIterableInternal.trackPushOpenWithCampaignIdor Iterable SDK logging).🧾 Changelog
Unreleased Fixes entry added for SDK-748 (Android-only behavior fix).
📹 Loom recording if applicable
N/A
🐞 Github Issues solved
N/A
📚 Docs PR if applicable
N/A