Repository navigation
Conversation
Every storyboard page of a video was downloaded as soon as it opened, one after the other, while the player was starting, and up to 48 of them stayed in memory. They are only looked at when the seekbar is dragged, which most playbacks never do. A page is now downloaded when a position it covers is previewed. While the finger moves only the latest page asked is loaded next, and the twelve most recently used pages are kept.
Owner
|
I need some time to think about this. An issue is that if we don't do preload new drags will not have previews. |
Contributor
Author
|
Sure, take ur time :) U're right, the first time u drag somewhere the preview comes a bit late. I did it because right now every video downloads all its previews when it opens (almost 1 MB for a 10 min video), even if u never touch the seekbar. Maybe a middle ground: nothing when the video opens, and load them all the first time the seekbar is touched? I haven't tried it tho. If u have any question just ask (˶ᵔ ᵕ ᵔ˶) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every storyboard page of a video is downloaded as soon as it opens, one after the other, starting before the first frame, and up to 48 of them stay in memory. They are only looked at when the seekbar is dragged.
A page is now downloaded when a position it covers is previewed. While the finger moves only the latest page asked is loaded next, and the 12 most recently used pages are kept.
Validation: