Repository navigation
Integrate project-scoped MindIE knowledge into InferRSI - #393
jiaran-king wants to merge 4 commits into
Conversation
Expose project-approved query and explain operations and bind reviewed reads to the frozen candidate, round, and independent evaluation. Keep configuration, workflow guidance, and synthetic test data independent of the validation tasks. Agent-assisted-by: Codex (implementation, integration and focused validation) Agent-assisted-by: Codex / gpt-6-luna [effort=max] (workflow smoke validation) Signed-off-by: jiaran-king <jiaranran2@gmail.com>
|
First full review at head What I checked
Needs a change or an answer
Optional
Accuracy and performance comparisons don't apply here. This is a read-only knowledge and evidence-import feature, and it doesn't change model numerics or claim a speedup. Reviewed: |
|
补充一次 Luna max 的实际行为验证(2026-11-11)。本轮在全新 Codex 会话中,只给出“实现昇腾 Triton RMSNorm 启动配置模块”的工程目标和交付要求,观察新版 InferRSI Skill 是否引导 Agent 按需获取知识并用于代码。 验证版本:实际运行的是
本轮记录标识为 结论:这轮已观察到预期的“按需查知识 → 读取正文 → 用于候选实现 → 留存关联记录”行为。本次范围是宿主侧行为与记录验证;Triton 设备编译、NPU 数值验证、实际编译缓存复用和性能测量仍待实机验证,记录保留 |
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
|
Incremental re-review: What this commit changes Verified at this head
Still open from my previous review (6792034283)
New in this revision: needs an answer or a change Accuracy and performance comparisons still don't apply. This revision is guidance and docs only. Reviewed: |
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
|
Scope clarification for review item 6 (re-review): The task owner explicitly requested in the implementation conversation:
The owner then authorized implementing that Skill change, validating it with two Luna-max agents, and updating PR #393. This comment records that updated scope in the public PR discussion. The earlier #374 proposal described the candidate-stage starting point; it did not itself establish the later knowledge-only extension. The reason for the extension is an observed routing gap: a knowledge-only task found insufficient Ascend Triton specialization material but skipped the available MindIE path because the old guidance was framed as a step before editing a candidate. The unresolved technical question can occur during research, diagnosis, planning, implementation or review, so the trigger now follows the knowledge gap. The accepted boundary is:
Fresh-session validation against the final receipt-wording update is now running for a knowledge-only task and a host launch-configuration optimization task. The previous history-bearing follow-up remains labeled as such and will not substitute for these new sessions. This scope record does not close #374 or replace independent PR review. |
|
Follow-up to re-review items 5–7. Final tested Skill: Current PR head is 5. Fresh sessions and linked receipts Two new
The receipt manifest also includes the extra DCP query. Input/result bytes match the original receipt hashes; session identifiers and local paths are redacted where indicated. The uploaded files were compared byte-for-byte with the reviewed publication copy, and the published reconstruction/host-check procedure was exercised. Observed limitation: the knowledge session unnecessarily queried MindIE once for an ordinary PyTorch DCP question. It found no applicable cards and ultimately used the original DCP package. A wrong package revision and a bounded-output omission are also retained in the logs. This demonstrates fresh-session Ascend retrieval, not zero irrelevant calls or statistical stability. No Triton/NPU execution or performance qualification was performed; device quality is 6. Scope and confirmation The task owner's explicit instruction and the reason for broadening the trigger are now recorded in the scope clarification. The trigger follows an unresolved Ascend-specific knowledge question, including knowledge-only work; existing read authorization and execution boundaries remain in place. 7. Receipt wording Commit Earlier review items 1–4 remain open. This update does not claim new runtime unit coverage, a MCP protocol fix, or full CI completion. |
Signed-off-by: Zhou ziheng <jiaranran2@gmail.com>
|
Incremental re-review: What changed Verified at this head
Needs a change or an answer
Accuracy and performance comparisons still don't apply. This delta is docs and guidance only. Reviewed: |
Governing Issue and delivery slice
Refs #374
This PR delivers the read-only MindIE knowledge and candidate-evidence handoff. A user enables one synced domain for a checkout once. In later sessions, the agent consults MindIE when an Ascend-specific question needs evidence during research, diagnosis, planning, implementation or review. Knowledge-only answers retain delivered source references; candidate work additionally associates those reads with the code and independent evaluation.
The task owner's explicit request to support unresolved Ascend questions before and beyond candidate editing is recorded in the scope confirmation. The earlier #374 candidate-stage proposal remains the starting point; this comment records the accepted scope of this delivery without closing the issue.
Workflow and architecture
When to consult MindIE
flowchart TD analyze["Analyze the task and available evidence"] --> need{"Unresolved Ascend-specific question?"} need -->|No| skip["Record the reason and proceed"] need -->|Yes| access{"Are project read tools available?"} access -->|No| skip access -->|Yes| search["Query using observed task conditions"] search --> hit{"Applicable versioned ref found?"} hit -->|No| skip hit -->|Yes| read["Explain selected refs and read delivered bodies"] read --> useful{"Usable guidance?"} useful -->|No| skip useful -->|Yes| apply["Use the guidance and note the exact source"] apply --> deliverable{"Requested deliverable"} skip --> deliverable deliverable -->|Research or diagnosis| answer["Answer with delivered sources and applicability limits"] deliverable -->|Candidate work| candidate["Edit and freeze the candidate"] candidate --> evaluate["Run independent InferRSI evaluation"] evaluate --> record["Record candidate, round, and run ID. Link reviewed reads when used."]Integration architecture
flowchart LR agent["Codex Agent with InferRSI Skill"] --> mcp["InferRSI stdio MCP"] agent --> cli["InferRSI CLI"] mcp -->|knowledge_query / knowledge_explain| adapter["Project read adapter"] cli -->|mindie query / mindie explain| adapter grant["One-time checkout grant"] --> adapter adapter --> worker["MindIE Python reader"] worker -->|Read-only SQLite| catalog[("Synced local knowledge catalog")] adapter --> receipts[("Local query and explain receipts")] agent --> snapshot["Frozen candidate"] snapshot --> runner["Independent InferRSI evaluation"] receipts -->|campaign import-mindie| trace["Reviewed campaign trace"] snapshot -->|Candidate and round| trace runner -->|Run ID| traceChanged artifacts and evidence
knowledge_queryandknowledge_explainthrough the InferRSI CLI and stdio MCP. Bind approval to the checkout identity and record local call receipts.Current Skill: fresh-session validation
Final tested revision:
44c2a650e57ad2b9b565ac2577e096b6678b1886. It adds the precise automatic receipt location to the Skill and guide. The bundled Skill Git blob matches the committed file.Current PR head is
1b40e2a150d33695e545ad91795b84deae5a1946. Its only change after the tested revision is plugin-guide wording thatresult.jsonis retained only when a response was received. The Skill Git blob remainsa067d2977c0069929615319437b6dc7529357e51, and runtime/knowledge bytes are unchanged, so the fresh sessions exercise the exact current Skill.Two new
gpt-6-luna/maxsessions usedfork_turns=none, with no prior experiment history or retrieval-route hint and no follow-up instructions before completion. Evidence bundle · Review response with direct receipts.The downloadable evidence includes prompts, orchestration metadata, call logs, request/result files, redacted receipts, candidate sources, frozen acceptance and a runnable independent validator. Input/result bytes were checked against the original receipt hashes; all uploaded files matched the reviewed publication copy. Knowledge attribution and redaction details are included.
An unnecessary MindIE query for the ordinary PyTorch DCP control returned no applicable cards; the answer used the original DCP package. The wrong-revision read and bounded-output omission are retained. These results establish fresh-session Ascend retrieval in the tested CLI cases, not zero irrelevant calls or statistical stability. No actual Triton/NPU execution, device compile-count or performance qualification occurred; device quality is
NOT_RUNand performanceINCONCLUSIVE.Earlier experiments at
f6194b5included a history-bearing follow-up after invalid CLI arguments. They remain historical observations and do not substitute for the fresh sessions above. The earlier three fixed-query comparisons found identical original-path outputs before/after a real MindIE read.Checks and dependencies
The receipt-wording update passed Skill validation and
git diff --check. The earlier 52 plugin tests atf6194b5are reused: the only later source-tree changes are receipt-location prose in the Skill and guide; runtime, knowledge data and test definitions are unchanged. The final bundle was exercised by both fresh sessions above.Earlier runtime validation at the pre-update head: 69 focused tests passed in
tests/test_mindie_context.py,tests/test_mindie_project.py, andtests/test_codex_plugin.py. Ruff andgit diff --checkpassed.The new workflow smokes covered host correctness and traceability. The earlier session-authorized RMSNorm A3 run verified correctness and source identity. Its performance result was INCONCLUSIVE because the identical-code control showed larger variation.
The earlier full-suite run recorded 3,574 passed, 11 failed, and 27 skipped. Ten failures reproduced on the base, and the remaining nested-repository case passed in isolation. The earlier ready-lane workflow at f6194b5 reported
action_requiredwith zero jobs created; no fresh full-suite CI result is claimed.Project reads use the installed, synced
mindie-knowledge 0.13.13catalog. Setup and the optional native MCP configuration are indocs/codex-plugin.md.Remaining work and Issue closure
Maintainers can review this read-only delivery and its evidence independently. Earlier review items 1–4 remain open: worker test/read-only behavior coverage, stdio MCP protocol coverage/error code, the permissive test exit assertion, and full CI/failure identifiers. This update addresses fresh-session evidence, scope confirmation and receipt wording. Remaining Issue requirements and goal acceptance are tracked in #374.