Repository navigation
docs: archive stale planning notes under docs/plans - #383
Conversation
Move the root phase-1 report and submission notes into docs/plans with dated names, retarget the report's relative links, and mark the three existing plan files as a historical archive. Agent-assisted-by: Cursor Grok 4.7 (implementer) Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Dong1017 <Dong1017@users.noreply.github.com>
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base 3f56064 and head f1e5a64. Full diff on opened; no prior review.
Verified:
- Rename
PHASE1_REPORT.md→docs/plans/2026-10-14-phase1-report.md. The historical-snapshot banner links now use../architecture.md#three-objective-delivery-framing,../reference-matrix.md, and../searchspace-matrix.md. Fromdocs/plans/those resolve to the samedocs/pages the previous root-relativedocs/...links targeted. - Pure rename
SUBMISSION_NOTES.md→docs/plans/2026-10-28-submission-notes.md(similarity 100%). - Historical-archive banner added after the title in
docs/plans/2026-10-18-inferrsi-rename.md,docs/plans/2026-10-18-negative-diagnostics.md, anddocs/plans/2026-10-19-campaign-plan-rfc.md, with a blank line before each file's existing blockquote. docs/reviews/source-audit-ac70272.mdnow namesdocs/plans/2026-10-14-phase1-report.mdin the licensing observation.
Optional follow-up: add the same historical-archive banner to docs/plans/2026-10-28-submission-notes.md. The phase1 report already carries a 2026-10-14 snapshot disclaimer; the three in-place plans gained the banner in this diff.
Not verified here: docs-only change, tests not run, CI not checked. Seeded evidence is the full patch, so unchanged lines inside the two renamed files were not re-read for other relative links, and the #three-objective-delivery-framing anchor was not re-opened in docs/architecture.md.
|
@zengchuang-hw @amy-why-3459 Please review this PR. This is an archive-only follow-up on the #372 layout track: Current head: |
amy-why-3459
left a comment
There was a problem hiding this comment.
LGTM
Reviewed the full diff at f1e5a642be3945587ee35a7c01a1ffde79a2864d (base 3f560642a44a1496aa4984ab936517693be2c788).
- The two renames are archive-only.
SUBMISSION_NOTES.mdmoves with its bytes unchanged. In the phase-1 report, only the three relative links in the header notice are retargeted, to../architecture.md,../reference-matrix.mdand../searchspace-matrix.md, and those were the only relative links in the file. - Each of the three existing plans gets one historical notice line, with no other body changes.
docs/reviews/source-audit-ac70272.md§15 now names the new path. - No protected knowledge path is touched (checked against
.github/knowledge-model-policy.json).declarationspassed. - CI on this head is green:
full-check(3.10/3.11),installed-package(3.10/3.11),lint-and-smokeandpr-references.
Add the same historical-archive notice used by the other plans under docs/plans, directly under the title. Agent-assisted-by: Cursor Grok 4.7 (implementer) Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Dong1017 <Dong1017@users.noreply.github.com>
08246fc
|
@zengchuang-hw @amy-why-3459 Please review the latest head. A follow-up commit is now on this PR: The earlier approvals from amy-why-3459 and cursor[bot] were on Checks on the new head so far: |
zengchuang-hw
left a comment
There was a problem hiding this comment.
Interim non-voting review of head 08246fc, against base 3f56064.
Incremental scope: f1e5a64 → 08246fc. I read the complete one-commit diff and the current submission-notes file. The only delta adds the historical-archive notice and a blank line. This resolves the optional suggestion in #383 (review). No additional technical defect or optional change found in this increment.
The prior full six-file assessment still applies: the phase-1 report's three relative links resolve, the original submission-note body is preserved, and no runtime or protected knowledge path changed. Previous review reference: #383 (review) (on the old head, now dismissed).
Before approval, please link the accepted scope/delegation for this bounded two-file archive slice. #372 still opens with “Status: Proposed” and explicitly says it does not authorize moves; its sole discussion comment does not supply that acceptance. The PR description says this is a follow-up but does not link a separate accepted decision. This is an evidence gap, not a claim that the archive is technically faulty, and does not require accepting the entire 3+1 proposal or closing #372/#362.
Checks: independently inspected the GitHub check records for this exact head. All eight check runs are now completed successfully, including full-check and installed-package on Python 3.10/3.11, lint-and-smoke, pr-references and both declarations runs.. I did not run local pytest or Ruff. The author's local test results remain author-reported. This comment is interim feedback, not an Approve or Request changes vote.
amy-why-3459
left a comment
There was a problem hiding this comment.
LGTM
Incremental review f1e5a642be3945587ee35a7c01a1ffde79a2864d..08246fcaad2865c49ba5c15389a262f7935099e8 (one commit). My earlier approval on f1e5a642 was dismissed by this push.
- The only change adds the same historical-archive notice line to
docs/plans/2026-10-28-submission-notes.md, directly under the title, matching the other archived plans. The note body is otherwise unchanged. - My full-diff assessment from the previous head still applies; no protected knowledge path is touched.
- CI on this head is green:
declarations,pr-references,lint-and-smoke,full-check(3.10/3.11) andinstalled-package(3.10/3.11).
|
@zengchuang-hw Thank you for the interim review on head This PR is a bounded archive-only slice, delegated by the repository owner (Dong1017) on 2026-11-10 (UTC+8). That confirmation was given outside this issue thread, so this comment is the public record of the delegation. It is not an acceptance of the #372 3+1 layout proposal, and it does not authorize closing #372 or #362. Accepted scope for this slice:
Current head remains |
zengchuang-hw
left a comment
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base 3f56064 and head 08246fc.
This completes my interim review: #383 (review). I independently assessed the original six-file diff and the incremental commit f1e5a64..08246fc. The increment only adds the historical-archive notice to the submission notes, resolving the optional suggestion.
The bounded archive scope and delegation are now publicly recorded at #383 (comment). This resolves the missing scope-record item from my interim feedback; it does not accept the broader #372 proposal or authorize closing #372/#362.
Verified: the two notes retain their original bodies apart from the declared header changes, the phase-1 report's three relative links and architecture anchor resolve, the in-repo reference is updated, and the plan notices are consistent. No runtime or protected knowledge content changes. No outstanding blocking findings or additional optional suggestions.
All nine current check runs on this head are successful, including declarations, pr-references, lint-and-smoke, full-check (3.10/3.11), and installed-package (3.10/3.11). I inspected remote checks; I did not run local pytest or Ruff, and the author's local results remain author-reported.
Independent reviewer: dot acting for zengchuang-hw under the user's direct instruction to review and approve passing changes. This is a revision-scoped PR approval, not Issue-level or campaign acceptance.
Governing Issue and delivery slice
Refs #372
docs/plans/as historical. It does not treat the 3+1 split as a newly accepted plan, and it does not close refactor: track architecture migration, integration PRs, and repository layout #372 or discussion: Knowledge / Harness / Benchmark 三模块目标架构——现状、原语、交接时序与遗留问题 #362.PHASE1_REPORT.mdandSUBMISSION_NOTES.mdmove intodocs/plans/under dated names, the phase-1 report's internal links are retargeted, the one in-repo path mention is updated, and each plan file underdocs/plans/has the same short historical-archive notice. File bodies are otherwise preserved. This is an archive (move + historical notice), not a deletion.AGENTS.md,evidence/, the skill library, skill-eval runbooks, both official matrices,docs/skill-coverage.md,docs/kv-reclamation-qualification.md, anddocs/examples/harness-improvement/summary.jsonare unchanged. Nodocs/migration/directory is created. Acceptance boxes on refactor: track architecture migration, integration PRs, and repository layout #372 and discussion: Knowledge / Harness / Benchmark 三模块目标架构——现状、原语、交接时序与遗留问题 #362 are untouched.Knowledge authorship declaration
Not applicable. This PR does not change protected knowledge paths or knowledge content. No policy exception is requested.
Changed artifacts and evidence
Moved with
git mv. A search of the tree before the move found one in-repo path hit forPHASE1_REPORT.mdand none forSUBMISSION_NOTES.md. No evidence manifest or other hash-pinned path named either file, so both moves proceeded.PHASE1_REPORT.mddocs/plans/2026-10-14-phase1-report.md../architecture.md,../reference-matrix.md, and../searchspace-matrix.md. Rename similarity 98%.SUBMISSION_NOTES.mddocs/plans/2026-10-28-submission-notes.mdHistorical-archive notice, inserted under the title and otherwise leaving the body as it was:
docs/plans/2026-10-18-inferrsi-rename.mddocs/plans/2026-10-18-negative-diagnostics.mddocs/plans/2026-10-19-campaign-plan-rfc.mddocs/plans/2026-10-28-submission-notes.md(follow-up on the same branch)The notice line is identical in all four files:
In-repo reference update:
docs/reviews/source-audit-ac70272.mdnow namesdocs/plans/2026-10-14-phase1-report.md. The rest ofdocs/reviews/is unchanged.git grepon the committed tree forPHASE1_REPORTandSUBMISSION_NOTESreturned no hits. Already-landed Issue and PR text was left as written. #372 still names the old root paths in its body; that text was not edited. Closed issue #43 also namesPHASE1_REPORT.mdand was left alone.docs/plans/git mvrenames abovedocs/plans/tests/test_template_layout.py::test_maintained_documentation_links_resolvepassed with the draft smoke and claim tests (11 passed) on the move, and again alone after the submission-notes notice (1 passed)git grepfor the old filenames: no hitsdocs/plans/historicalChecks and dependencies
python3 -m pytest tests/test_template_layout.py tests/test_smoke.py tests/test_claim.py— 11 passed in 0.23s, andpython3 -m ruff check src tests— all checks passed (ruff 0.17.4). After the submission-notes notice:python3 -m pytest tests/test_template_layout.py::test_maintained_documentation_links_resolve— 1 passed in 0.20s. The moved submission notes contain no relative links to retarget.pytestwas not run. No workflow, Python, or evidence file changed.Remaining work and Issue closure