Repository navigation
chore: move skill-eval fixtures out of docs/examples - #381
Conversation
Move the skill-comparison and skill-eval-pr fixture trees under tests/fixtures and point the tests, docs, case mapping, and skill-eval workflow at those directories. Agent-assisted-by: Cursor Grok 4.7 (implementer) Co-authored-by: Dong1017 <Dong1017@users.noreply.github.com> Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com>
|
@zengchuang-hw @amy-why-3459 Please review this fixture-path cleanup. Head SHA: |
Skill evaluationPLANNED: not executed; there are no task outcomes yet.
Author verification steps (nonpaid; not yet run)
Evidence and logs · Retention: 30 days. Plan bindings, budget, frozen exam and advisory detailsAdvisory: obtain missing evidenceRetained evidence availability: planned / unexecuted. No approval or merge authorization is issued.
Model/settings:
Automatic execution / cumulative PR budget: {"reason":"Trusted configuration or pricing missing, invalid or expired","remaining_usd":"unknown","reserved_or_unresolved_usd":"unknown","spent_or_legacy_usd":"unknown","state":"blocked"}Provider/settings: Uncovered / unsupported paths (20)
|
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base b8df371 and head bac4f89 (full diff, opened, no prior review).
Verified:
- Renames move
docs/examples/skill-comparison/totests/fixtures/skill-comparison/(addition.json,update.json,cases.json,pr133-diagnostic-case05.json,report-example.json,report-example.md) anddocs/examples/skill-eval-pr/summary-example.mdtotests/fixtures/skill-eval-pr/summary-example.md. The JSON fixtures and the summary excerpt are byte-identical renames. tests/fixtures/skill-comparison/report-example.mdbacklink is../../../docs/skill-eval-comparison.md, which resolves todocs/skill-eval-comparison.md. The siblingreport-example.jsonlink stays in the same directory.docs/skill-eval-comparison.mdmarkdown links and theskill_eval_compare prepare --configexample usetests/fixtures/skill-comparison/. Links indocs/*.mduse../tests/fixtures/...fromdocs/.docs/skill-eval-pr.mdpoints the offline summary excerpt at../tests/fixtures/skill-eval-pr/summary-example.md.tests/test_skill_eval_feedback.pyloadspr133-diagnostic-case05.jsonwithPath(__file__).parents[1](repository root) undertests/fixtures/skill-comparison/.tools/skill_eval_pr_cases.jsonkeeps the../prefix used fromtools/, so../tests/fixtures/skill-comparison/...resolves totests/fixtures/skill-comparison/.....github/workflows/skill-eval-pr.ymlpath filter liststests/fixtures/skill-comparison/**where it previously listeddocs/examples/skill-comparison/**.docs/module-layout.mdrecords both fixture directories and still says not to overwriteskill_eval_pr_support.pyandskill_eval_compare_support.py.
Not verified here: tests were not executed and CI was not checked. Rename-only fixture bodies had no hunks, so embedded path strings inside those files were not re-read beyond this patch.
amy-why-3459
left a comment
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base b8df371 and head bac4f89 (new PR, full diff).
Verified:
- Seven renames from
docs/examples/skill-comparison/anddocs/examples/skill-eval-pr/totests/fixtures/skill-comparison/andtests/fixtures/skill-eval-pr/; onlyreport-example.mdchanges content (backlink now../../../docs/skill-eval-comparison.md, resolves correctly). - Reference updates in
tests/test_skill_eval_feedback.py(TASK_PATH),tools/skill_eval_pr_cases.json(../tests/fixtures/...relative totools/),.github/workflows/skill-eval-pr.ymlpath filter,docs/skill-eval-comparison.md,docs/skill-eval-pr.md, anddocs/module-layout.md. - Code search on
mainforskill-comparison,docs/examplesandsummary-exampleonly hits files this PR updates, so no stale reference to the old paths is left behind. - CI on this head is green: lint-and-smoke, full-check (3.10/3.11), installed-package (3.10/3.11), pr-references, declarations, skill-eval plan/publish.
Note (non-blocking): the workflow uses pull_request_target, so the new path filter only takes effect after merge.
Governing Issue and delivery slice
Refs #372
Refs #362
docs/examples/skill-comparison/now lives attests/fixtures/skill-comparison/, anddocs/examples/skill-eval-pr/now lives attests/fixtures/skill-eval-pr/. Every in-repo citation of the old paths is updated in the same change.docs/examples/harness-improvement/stays.docs/plans/,PHASE1_REPORT.md,SUBMISSION_NOTES.md,evidence/,docs/reviews/, and skill-library content stay. Existing helpersskill_eval_pr_support.py,skill_eval_compare_support.py,skill_eval_pr_demo.py,skill_eval_compare_demo.py, andtests/fixtures/skill_eval_engineering/are unchanged.cli.py,arguments.py,harness/runner.py, andpyproject.tomlare untouched. Issues 372 and 362 stay open. This is not Issue acceptance.Knowledge authorship declaration
Not applicable. This PR does not change protected knowledge paths, knowledge content, or Bundle revision rules. No policy exception is requested.
Changed artifacts and evidence
Moved with
git mv. File bytes are unchanged except the one relative link called out below.docs/examples/skill-comparison/addition.jsontests/fixtures/skill-comparison/addition.jsondocs/examples/skill-comparison/cases.jsontests/fixtures/skill-comparison/cases.jsondocs/examples/skill-comparison/pr133-diagnostic-case05.jsontests/fixtures/skill-comparison/pr133-diagnostic-case05.jsondocs/examples/skill-comparison/report-example.jsontests/fixtures/skill-comparison/report-example.jsondocs/examples/skill-comparison/report-example.mdtests/fixtures/skill-comparison/report-example.mddocs/examples/skill-comparison/update.jsontests/fixtures/skill-comparison/update.jsondocs/examples/skill-eval-pr/summary-example.mdtests/fixtures/skill-eval-pr/summary-example.mdUpdated references:
tests/test_skill_eval_feedback.pyTASK_PATHnow readstests/fixtures/skill-comparison/pr133-diagnostic-case05.jsondocs/skill-eval-comparison.mdaddition.json,update.json,report-example.md, andreport-example.json, plus theprepare --configpathdocs/skill-eval-pr.mdsummary-example.md.github/workflows/skill-eval-pr.ymlpull_request_targetpath filter now watchestests/fixtures/skill-comparison/**tools/skill_eval_pr_cases.jsoncasesforinference-benchmark-design,audit-fixed-workload-claim, andoptimization-search-policydocs/module-layout.mdtests/fixtures/skill-comparison/report-example.mddocs/skill-eval-comparison.mdupdated for the new depthtests/fixtures/skill-eval-pr/summary-example.mdstill links totests/test_skill_eval_pr.pyandtests/fixtures/skill_eval_pr_demo.py. Those relative links were left as they were because the directory depth is unchanged and both targets still resolve.docs/examples/harness-improvement/summary.jsonremains the only file underdocs/examples/.git grepon the committed tree fordocs/examples/skill-comparison,docs/examples/skill-eval-pr,examples/skill-comparison, andexamples/skill-eval-prreturned no hits. Past Issue and PR comments were not edited.git mvrenames listed abovereport-example.mdat 98% for the relative linkgit grepfor the old path strings: no hitscasespaths.github/workflows/skill-eval-pr.ymltests/fixtures/skill-eval-pr/**; the old workflow did not watch that treetests/test_skill_eval_feedback.pyruff checkpassed (ruff 0.17.4)Checks and dependencies
--no-lazy-fetch, Git >= 2.45):python3 -m pytest tests/test_skill_eval_feedback.py tests/test_skill_eval_pr.py::test_maintained_mapping_selects_real_acceptance_paths tests/test_skill_eval_pr.py::test_workflow_separates_execution_and_publication_credentials tests/test_skill_eval_auto.py::test_workflow_is_opt_in_and_controller_is_only_budget_writer tests/test_skill_eval_planning_boundaries.py::test_expired_paid_configuration_preserves_provider_plan_and_free_publication --override-ini addopts= -q --tb=no— 21 passed in 0.70s. That set reads the moved diagnostic case, selects real acceptance cases throughtools/skill_eval_pr_cases.json, and loads the edited workflow YAML.python3 -m ruff check tests/test_skill_eval_feedback.py— All checks passed (ruff 0.17.4).git diff --check HEAD~1— clean.git grepfor the four old path strings — no hits.ruff check src testsandruff check src tests toolswere not run; the only touched Python file was checked. Ready CI, hardware, GPU/NPU, and model runs were not run. A green check is not campaign or effect acceptance.cli.py,arguments.py,harness/runner.py, andpyproject.toml. This branch does not edit them. task: Apps 应用层详细设计与迁移计划(CLI / Python / Plugin) #371 still names the Apps package. No merge gate was added to feat: support shared YAML task input #367 or feat: share RSI optimization management across project and benchmark tasks #338.Remaining work and Issue closure
docs/plans/,PHASE1_REPORT.md, andSUBMISSION_NOTES.md. Those files were not moved. Production Apps assembly, S2/S3/S4 production work, and the undecided contract items stay outside this diff.Handoff (only when an actual handoff or decision changed)
bac4f895063cf7dec827dd0af8d4c14f78fd9b31.