Skip to content

fix(labels): align labels.json with live area:harness - #373

Merged
Dong1017 merged 1 commit into
mainfrom
cursor/align-area-harness-label-474c
Nov 9, 2026
Merged

Dong1017 merged 1 commit into
mainfrom
cursor/align-area-harness-label-474c

Conversation

@Dong1017

@Dong1017 Dong1017 commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

Governing Issue and delivery slice

Refs #362

Knowledge authorship declaration

Not applicable. .github/labels.json is not a knowledge-admission path. Attribution for this mechanical manifest edit:

{
  "schema_version": 1,
  "head_sha": "a4be1b8eda39768b4cbc30148c9051012e4c8367",
  "human_only": false,
  "material_ai_authors": [
    {
      "tool": "Cursor",
      "model_id": "grok-4.7",
      "effort": "unknown",
      "role": "author"
    }
  ]
}

Changed artifacts and evidence

Requirement Actual change Check / evidence and result Remaining gap
Manifest matches the live harness label .github/labels.json name and description JSON parses; 21 names, no duplicates; manifest_problems reports none; description length 66. git diff --check is clean. Diff is two lines in that file only. Nightly check_labels.py against the live label list was not run, so CI green is not this acceptance
Sync config will not restore area:workbench Same manifest is the only in-tree area:workbench reference on 68dbd5e8 git grep area:workbench on that main found only this file. Issue templates and tools/skill_eval_*_config.json do not name it. ci-nightly.yml compares the manifest with the repository labels and does not write labels None in this diff

Checks and dependencies

  • Checks actually run (result and tested scope): Local JSON parse, unique-name check, tools/check_labels.py manifest_problems, and git diff --check on the one-file diff. Passed. Live label read (no write) shows area:harness, color 0052cc, and the same description. Color is not stored in labels.json because the manifest schema allows only name, group, and description.
  • Failed, skipped, timed-out or not-run checks (if applicable): Pytest, the nightly workflow, and any label-sync or deploy workflow were not run. No hardware, model, or experiment run.
  • Dependencies / shared interfaces / integration assumptions (if applicable): The rename is already applied on the repository (46 issues and 32 PRs followed the existing label id). This commit prevents the manifest from drifting back to area:workbench.

Remaining work and Issue closure

Handoff (only when an actual handoff or decision changed)

  • Accepted decision / status and link: Live label rename is already done. Config alignment is this PR.
  • Recipient and communication status: Review requested from zengchuang-hw and amy-why-3459.
  • Application status and artifact/evidence: pending merge; manifest edit is in this head
  • Relevant workspace state and next action: Do not merge from this change set. Do not start the label-sync workflow.
Open in Web Open in Cursor 

The repository label is already area:harness. Update the checked-in
manifest so the nightly drift check does not report or restore
area:workbench.

Agent-assisted-by: Cursor Grok 4.7 (author)
Signed-off-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Dong1017 <Dong1017@users.noreply.github.com>
@Dong1017 Dong1017 added the area:process Repo-wide process, governance, privacy and security rules label Nov 9, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PR review verdict — PASS
Reviewed base 68dbd5e and head a4be1b8 (full diff; no prior review).

Verified:

  • .github/labels.json: the area label name changes from area:workbench to area:harness in the same object.
  • The description moves with that name, from "CLI workbench: profile, A/B loop, quality gates, evidence reports" to "Harness module: profile, A/B loop, quality gates, evidence reports".
  • group stays area. The surrounding JSON array structure is unchanged.
  • The revision is this one declaration. No callers or tests are in the diff.

Not verified here:

  • Live GitHub label inventory and what the next label sync does with a manifest that no longer lists area:workbench.
  • Remaining area:workbench references in issue templates, workflows, or docs outside this diff.
  • CI was not run.

No blocking findings on the reviewed head.

Dong-bot review under the standing InferRSI queue delegation. This Approve is one vote; merge still needs a second qualifying approval and passing required checks.

Dong1017 commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator Author

@zengchuang-hw @amy-why-3459 Please review this PR. It only aligns .github/labels.json with the existing area:harness label; no architecture implementation or directory migration is included.

@amy-why-3459 amy-why-3459 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PR review verdict — PASS
Reviewed base 68dbd5e811a043f113e17e90b3bbe79622cbf7a5 and head a4be1b8eda39768b4cbc30148c9051012e4c8367.

  • The diff changes only .github/labels.json: one entry is renamed from area:workbench to area:harness, and its description is updated.
  • The new name and description exactly match the live repository label area:harness. The live repo no longer has an area:workbench label.
  • A code search on main finds area:workbench only in this manifest, so no other in-tree config would bring the old name back.
  • CI on this head is green: declarations, pr-references, lint-and-smoke, full-check (3.10/3.11) and installed-package (3.10/3.11) all pass.

Not verified by me: the nightly check_labels.py run against live labels.

@Dong1017
Dong1017 merged commit 9f61a83 into main Nov 9, 2026
8 checks passed

Copy link
Copy Markdown
Contributor

Follow-up to the review request. The merge landed while I was checking the live inventory.

I ran the nightly workflow's read-only label checker on a4be1b8eda39768b4cbc30148c9051012e4c8367 with the current GitHub label inventory. The manifest entry matches the live area:harness name and description. The checker reports one remaining difference: area:workbench: in the repository, missing from labels.json. GitHub currently lists the old label on #374. Manifest diff · Nightly checker.

If the intended end state is one Harness label, the repository maintainer can replace the old label on #374 with area:harness, retire the old label once it has no remaining uses, and rerun the read-only check against the current inventory. An exit code of 0 closes the drift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:process Repo-wide process, governance, privacy and security rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants