Repository navigation
fix(labels): align labels.json with live area:harness - #373
Conversation
The repository label is already area:harness. Update the checked-in manifest so the nightly drift check does not report or restore area:workbench. Agent-assisted-by: Cursor Grok 4.7 (author) Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Dong1017 <Dong1017@users.noreply.github.com>
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base 68dbd5e and head a4be1b8 (full diff; no prior review).
Verified:
.github/labels.json: the area label name changes fromarea:workbenchtoarea:harnessin the same object.- The description moves with that name, from "CLI workbench: profile, A/B loop, quality gates, evidence reports" to "Harness module: profile, A/B loop, quality gates, evidence reports".
groupstaysarea. The surrounding JSON array structure is unchanged.- The revision is this one declaration. No callers or tests are in the diff.
Not verified here:
- Live GitHub label inventory and what the next label sync does with a manifest that no longer lists
area:workbench. - Remaining
area:workbenchreferences in issue templates, workflows, or docs outside this diff. - CI was not run.
No blocking findings on the reviewed head.
Dong-bot review under the standing InferRSI queue delegation. This Approve is one vote; merge still needs a second qualifying approval and passing required checks.
|
@zengchuang-hw @amy-why-3459 Please review this PR. It only aligns |
amy-why-3459
left a comment
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base 68dbd5e811a043f113e17e90b3bbe79622cbf7a5 and head a4be1b8eda39768b4cbc30148c9051012e4c8367.
- The diff changes only
.github/labels.json: one entry is renamed fromarea:workbenchtoarea:harness, and its description is updated. - The new name and description exactly match the live repository label
area:harness. The live repo no longer has anarea:workbenchlabel. - A code search on main finds
area:workbenchonly in this manifest, so no other in-tree config would bring the old name back. - CI on this head is green:
declarations,pr-references,lint-and-smoke,full-check (3.10/3.11)andinstalled-package (3.10/3.11)all pass.
Not verified by me: the nightly check_labels.py run against live labels.
|
Follow-up to the review request. The merge landed while I was checking the live inventory. I ran the nightly workflow's read-only label checker on If the intended end state is one Harness label, the repository maintainer can replace the old label on #374 with |
Governing Issue and delivery slice
Refs #362
area:workbenchtoarea:harness. This PR only updates the checked-in label manifest so the nightly drift check matches that rename. It does not implement the Harness module move tracked by discussion: Knowledge / Harness / Benchmark 三模块目标架构——现状、原语、交接时序与遗留问题 #362 or refactor: track architecture migration, integration PRs, and repository layout #372..github/labels.jsonnow namesarea:harnessand uses the live descriptionHarness module: profile, A/B loop, quality gates, evidence reports.Knowledge authorship declaration
Not applicable.
.github/labels.jsonis not a knowledge-admission path. Attribution for this mechanical manifest edit:Changed artifacts and evidence
.github/labels.jsonname and descriptionmanifest_problemsreports none; description length 66.git diff --checkis clean. Diff is two lines in that file only.check_labels.pyagainst the live label list was not run, so CI green is not this acceptancearea:workbencharea:workbenchreference on68dbd5e8git grep area:workbenchon that main found only this file. Issue templates andtools/skill_eval_*_config.jsondo not name it.ci-nightly.ymlcompares the manifest with the repository labels and does not write labelsChecks and dependencies
tools/check_labels.pymanifest_problems, andgit diff --checkon the one-file diff. Passed. Live label read (no write) showsarea:harness, color0052cc, and the same description. Color is not stored inlabels.jsonbecause the manifest schema allows only name, group, and description.area:workbench.Remaining work and Issue closure
Handoff (only when an actual handoff or decision changed)