Skip to content

Add source-bound TTS playout benchmark guidance - #339

Merged
Dong1017 merged 4 commits into
InferMatrixLab:mainfrom
Dong1017:codex/issue91-faster-cosyvoice-source
Nov 10, 2026
Merged

Dong1017 merged 4 commits into
InferMatrixLab:mainfrom
Dong1017:codex/issue91-faster-cosyvoice-source

Conversation

@Dong1017

@Dong1017 Dong1017 commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Streaming TTS measurements can conflate the server's playback estimate with the client's arrival and playback clock, and can omit accumulated synthesis work. This change adds a source-bound interpretation to the existing inference-benchmark-design owner for PCM sample boundaries, dependent chunk batching, accumulated vocoding, and timing denominators.

The source is yuekaizhang/faster-cosyvoice at f1049c59. The readset records inspected files and their individual rights. Overall repository rights remain UNKNOWN; selected Apache-2.0 headers do not extend to other files. The reference contains original analysis and immutable links.

Current-main integration (head a0978f59a24115e60e894a4bfdd5f57ea3f37ddb)

This follows the agreed order after #332, #322, #360, #324, #325 and #359 landed (main 14fa1f578655bbdcd101b8c4235299fc3d8360d3), and addresses the cross-PR integration blockers in the earlier review. The branch fast-forwards from the previous head 881159057101c639504bd16d889c81cb5d514ee1; no history was rewritten.

Commit Parents Content
b2d62f8192903ab31f8e8828f4e630a1bec776b7 previous head, main 14fa1f57 Combined source, described below. Generated projections kept main's bytes until regeneration
a0978f59a24115e60e894a4bfdd5f57ea3f37ddb b2d62f81 Projections regenerated by main's unchanged writers from the combined source

Xe-Forge (#322) and NInfer (#325) already extend inference-benchmark-design, so four hand-written files needed a real merge. Every overlap is additive; main's additions come first, then this PR's:

  • metadata.json: merged by JSON field. Main's 3 added sources, 2 limitations and 4 readsets stay; this PR appends the Faster CosyVoice source, 1 limitation and 2 readsets. Any concurrent edit that is not a pure append would have stopped the merge.
  • SKILL.md: the 6-line dependency-aware TTS playout paragraph keeps its original place, before the treatment-delivery paragraph.
  • docs/reference-matrix.md: the Faster CosyVoice row (1 line) is the last row of the source table, after main's rows.
  • docs/searchspace-matrix.md: the 13-line Faster CosyVoice section follows main's sections at the end of the file.

The two new reference files are byte-identical to the previous head. With the shared source snapshot from #359, regeneration changed 3 generated files: the inference-benchmark-design record, _provenance.json (now pinned to b2d62f81) and docs/skill-coverage.md. Relative to main, the head changes 9 paths: the 6 canonical paths and these 3.

Commands run at this head, all exit 0:

python tools/build_skill_index.py --source-revision b2d62f8192903ab31f8e8828f4e630a1bec776b7
python tools/build_skill_coverage.py
python tools/build_skill_index.py --source-revision b2d62f8192903ab31f8e8828f4e630a1bec776b7 --check   # 80 metadata records current
python tools/build_skill_coverage.py --check   # matches sources

git merge-tree --write-tree 14fa1f57 a0978f59 is conflict-free and produces exactly this head's tree 8899009dd667247e03a3c5f80366fd128a34c4fd.

A local focused test run at this head did not complete: the host stopped it for low memory, so it gives no result. Hosted Python 3.10/3.11 full and installed-package checks are the test evidence for this head.

Earlier head evidence (881159057101c639504bd16d889c81cb5d514ee1)

The following results apply to the previous head over main 663f3b32 and are not substituted for current-head checks.

Canonical source M: 8daa93343cb7a33069b6c6b53a82eb4ec14941a0. Native generated G and head: 881159057101c639504bd16d889c81cb5d514ee1.

The native coverage and index write/check modes passed from the actual M; the index contains 79 records. Final-head source readers and whole-resource Collect read both new resources completely, with 12 selected resources and no omissions. Seven existing local test modules passed with 104 passed and 5 skipped. A Windows checkout initially materialized the new JSON with CRLF, causing a hash mismatch; restoring the committed LF blob resolved the mismatch without changing the Git tree or relaxing validation.

Ready CI passed on the tested merge of then-current main and that head; its tree equals that head's tree. Python 3.10 and 3.11 each reported 3,544 passed, 13 skipped, 1 warning and 284 subtests; both isolated installed-wheel checks read 127 source-grounded records. The head-bound model-policy check passed. Independent Sol/ultra static review covered that head and found no blocking issue; it did not run the source or evaluate efficacy.

Limits

Source observations and author-reported measurements remain distinct. This candidate is not_run and efficacy is not_evaluated; upstream execution, device, audio quality, service and performance have not been evaluated. The snapshot pin b2d62f81 is a branch commit; after a squash merge it is not an ancestor of main, and the next knowledge PR re-pins when it regenerates. The pending Embodied increment (#342) is not imported; it will be integrated on top of this PR after it lands.

Refs #91. Refs #177.

Knowledge authorship declaration

{
  "schema_version": 1,
  "head_sha": "a0978f59a24115e60e894a4bfdd5f57ea3f37ddb",
  "human_only": false,
  "material_ai_authors": [
    {
      "tool": "Codex",
      "model_id": "gpt-6.1-sol",
      "effort": "max",
      "role": "author"
    },
    {
      "tool": "Claude Code",
      "model_id": "claude-opus-5-5",
      "effort": "xhigh",
      "role": "author"
    }
  ]
}

Trace Faster CosyVoice PCM credit, dependent chunk batching and measured
cost boundaries through the existing benchmark method. Retain source-only
candidate status, UNKNOWN repository rights and hardware applicability.

Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com>
Agent-assisted-by: Codex / gpt-6.1-sol [effort=max] (author)
Build the complete native catalog and coverage from source revision
8daa933.

Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com>
Agent-assisted-by: Codex / gpt-6.1-sol [effort=max] (author)
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T21:31:40.993734Z 8811590 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Skill evaluation

PLANNED: not executed; there are no task outcomes yet.
No approval, model efficacy or current-head test result is implied.

  • Next: run the pinned source/index --check below at head a0978f59a24115e60e894a4bfdd5f57ea3f37ddb.
  • Blockers: Executable snapshot entries are not supported. No unsafe fallback; details below.
  • Selected comparisons: 0 · Estimated task calls: 0. Uncovered/unsupported changes: 9; Canonical library paths: 4; Generated projection paths: 2; Other paths: 3. These are paths, not independent claims.
  • Return: command, input/source pin, exit status, outputs/failures and untested claims for independent verified/refuted/unverified disposition.
Author verification steps (nonpaid; not yet run)
  1. Bind the checkout. Run git rev-parse HEAD; it must equal a0978f59a24115e60e894a4bfdd5f57ea3f37ddb. If it differs, obtain a current plan; do not reuse old results.
  2. Check source/index consistency. At that PR checkout, using the reviewed repository tool and its documented development dependencies, run:
python tools/build_skill_index.py --source-revision b2d62f8192903ab31f8e8828f4e630a1bec776b7 --check

The declared source pin matches this head's canonical library bytes. The command has not run: retain its exit code and full drift/success output. It checks the generated projection, not claim truth or skill efficacy.
No supported automatic comparison is selected. Review the canonical changes and explain which claims need evidence, are unaffected, or remain unverified; do not treat generated records as separate behavioral claims.

  • inference-benchmark-design
    Selected by the trusted path mapping: src/inferrsi/data/skill_library/methods/inference-benchmark-design/SKILL.md; src/inferrsi/data/skill_library/methods/inference-benchmark-design/metadata.json (+2 more in the plan).
    Unsupported: Executable snapshot entries are not supported. No snapshot prepared; task metadata is in details. Do not relax snapshot safety.
    Uncovered scope by location: Canonical library paths: 4; Generated projection paths: 2; Other paths: 3. Path counts are not claim counts; no metadata-only conclusion is inferred.
  1. Return evidence for independent review: head, check/task/source pin, command, environment, exit status, outputs/failures and untested claims. Label scripted controls. Request each claim's disposition: verified, refuted or unverified; this plan proves neither model provenance nor benefit.
    Check recipes and evidence limits

Evidence and logs · Retention: 30 days.
Retained artifacts are verifiable only before Unix time 1796898227 while the linked artifact is available. Expired evidence is unverified.

Plan bindings, budget, frozen exam and advisory details

Advisory: obtain missing evidence

Retained evidence availability: planned / unexecuted. No approval or merge authorization is issued.
Applicable only while these revisions and inputs match the current PR.
Paid execution requires trusted label authorization and cumulative PR reservation. Unknown accounting blocks new paid calls; planning is not execution.
Pipeline evidence only; offline fixed outputs do not establish skill efficacy.
Unchanged-correct is valid neutral evidence, not incremental benefit.
Content/source review and authorship admission remain separate.
Trusted regrading checks retained answers, not model/hardware provenance or a hostile executor; this is not an efficacy certification.

  • Retained evidence is planned / unexecuted.
  • No supported comparison cases were selected.
  • Uncovered/unsupported scope needs a case or explicit reviewer disposition.
    Plan SHA-256: 0a6ecf1d9ff72563aa9e30db1f1d5c6a7762c16d3ceeb4dd4ddd9692c9238838
    Base: 14fa1f578655bbdcd101b8c4235299fc3d8360d3 · Head: a0978f59a24115e60e894a4bfdd5f57ea3f37ddb
    Trusted implementation: 14fa1f578655bbdcd101b8c4235299fc3d8360d3

Model/settings: {"effort":"not_applicable","name":"claude-opus-5-5"}
Budget: {"comparisons":0,"estimated_calls":0,"limits_per_comparison":{"campaign_seconds":600,"max_task_calls":2,"repeats":1,"timeout_seconds":180,"token_stop_new_trials":200000},"provider_config_sha256":"b28d80f8194fbe0f5a9f01515efb24b218979fd45f702776560da276f4b30d04","reservation":null}

Skill Comparison Cases Estimated calls
inference-benchmark-design unsupported snapshot: Executable snapshot entries are not supported — 0

Selection/task metadata (not a relevance verdict):

{"adapter":"audit","basis":"trusted_path_mapping","matched_paths":["src/inferrsi/data/skill_library/methods/inference-benchmark-design/SKILL.md","src/inferrsi/data/skill_library/methods/inference-benchmark-design/metadata.json","src/inferrsi/data/skill_library/methods/inference-benchmark-design/references/dependency-aware-tts-playout.md","src/inferrsi/data/skill_library/methods/inference-benchmark-design/references/faster-cosyvoice-source.json"],"tasks":[{"evidence_scope":"http_fixed_workload","id":"audit-threshold","request":"Audit the fixed input report using its contract. Compute the median of per-trial request means, including every request in each trial, and the percentage reduction relative to the baseline aggregate.","split":"holdout"}]}

Automatic execution / cumulative PR budget:

{"reason":"Trusted configuration or pricing missing, invalid or expired","remaining_usd":"unknown","reserved_or_unresolved_usd":"unknown","spent_or_legacy_usd":"unknown","state":"blocked"}

Projection check selection (not an executed result):

{"declared_in":"src/inferrsi/data/repo_packs/inferrsi/knowledge/_provenance.json","source_revision":"b2d62f8192903ab31f8e8828f4e630a1bec776b7","status":"ready"}

Provider/settings: {"client":{"api_version":"2023-06-01","endpoint":"https://yibuapi.com/v1/messages","kind":"anthropic-messages-full-context-v1","max_output_tokens":4096,"max_read_bytes":32768,"max_request_bytes":262144,"max_requests":1,"max_tool_calls":12,"provider":"yibuapi"},"limits":{"token_stop_new_trials":200000},"model":{"effort":"not_applicable","name":"claude-opus-5-5"},"pricing":{"currency":"USD","expires_at":1793271228,"group":"default","max_input_tokens":1000000,"model":"claude-opus-5-5","rate_evidence":"https://github.com/InferMatrixLab/InferRSI/issues/215#issuecomment-6467531341","rates":{"cache_read":"0.4","cache_write":"10","input":"8","output":"40"},"request_fee":"0","unit":"per_million_tokens"},"spend_limit":{"amount":"200","currency":"USD"}}

Uncovered / unsupported paths (9)
  • uncovered: "docs/reference-matrix.md"
  • uncovered: "docs/searchspace-matrix.md"
  • uncovered: "docs/skill-coverage.md"
  • uncovered: "src/inferrsi/data/repo_packs/inferrsi/knowledge/_provenance.json"
  • uncovered: "src/inferrsi/data/repo_packs/inferrsi/knowledge/common/skills/inference-benchmark-design.json"
  • unsupported: "src/inferrsi/data/skill_library/methods/inference-benchmark-design/SKILL.md"
  • unsupported: "src/inferrsi/data/skill_library/methods/inference-benchmark-design/metadata.json"
  • unsupported: "src/inferrsi/data/skill_library/methods/inference-benchmark-design/references/dependency-aware-tts-playout.md"
  • unsupported: "src/inferrsi/data/skill_library/methods/inference-benchmark-design/references/faster-cosyvoice-source.json"

@agent-ci-infra-bot

Copy link
Copy Markdown

This PR adds a source-bound Faster CosyVoice reference and per-file readset under the existing inference-benchmark-design owner, with the reference-matrix row, a SearchSpace context section, sidecar updates and the regenerated 79-record index/coverage projections; the body edit only adds the completed CI/test evidence. I found no blocking defect: tools/build_skill_index.py --source-revision 8daa933… --check reports "Skill index is current: 79 metadata records", tools/build_skill_coverage.py --check matches its sources, the metadata paths list equals the 33-entry readset exactly, all local links resolve, the packaged reader returns both new resources, and the knowledge/coverage/collect/install test modules passed (136 passed, 3 skipped across the modules I ran). The upstream source text was not independently re-read here (the read token is scoped to this repository), so the document's source observations rest on the PR's own labeled readset; the edited body's CI claim is consistent with the green checks at this head, and no earlier bot findings needed reconciliation. Relevance: current — main is still 663f3b3, this PR's base. Labels: area:knowledge, kind:docs (knowledge-library reference delivery plus regenerated catalog).

Reviewed commit: 8811590
Coverage: Checkout: 2647 files at 8811590 in a git worktree with the repository's history

@agent-ci-infra-bot agent-ci-infra-bot Bot added area:knowledge Knowledge line: packs, skill library, knowledge admission bot-reviewed kind:docs Documentation and template delivery labels Nov 3, 2026
@agent-ci-infra-bot

Copy link
Copy Markdown

This PR adds a pinned Faster CosyVoice source record and an original "dependency-aware TTS playout" reference to the existing inference-benchmark-design owner, with the Reference/SearchSpace matrix notes, sidecar entries, and regenerated catalog/coverage projections. I found no blocking defect: tools/build_skill_index.py --source-revision 8daa933… --check reports "Skill index is current: 79 metadata records", both generator write and --check modes leave the tree clean, tools/build_skill_coverage.py --check matches, the 33 metadata paths equal the 33-entry readset exactly, the reader returns both new resources (13-file bundle), the local references/anchors are consistent, ruff passes, and the repo test suite shows the same environment-only failures before and after the change while hosted full checks at this head are green. The upstream source text could not be independently re-read here (the read token is scoped to this repository), so its source observations rest on the PR's own labeled readset and immutable links; no earlier inline review findings exist to reconcile. Relevance: current — main is still 663f3b3, the PR's base. Labels: area:knowledge, kind:docs (source-bound knowledge reference and regenerated projections for an existing owner).

Reviewed commit: 8811590
Coverage: Checkout: 2647 files at 8811590 in a git worktree with the repository's history

@Dong1017 Dong1017 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source-only LGTM at 88115905. I found no blocking defect in the new Faster CosyVoice interpretation or its current knowledge projection.

  • The source supports the distinctions between PCM receipt/playback and server credit, dependent same-session chunks, accumulated vocoding work, and token-derived versus delivered-audio denominators.
  • Overall rights remain UNKNOWN; file-header exceptions, inherited attribution and author-reported quality/performance limits are retained. This adds methodology guidance to the existing owner.
  • @Dong1017 retains integration. If another pending knowledge amendment lands first, preserve the combined canonical inputs and regenerate the affected projections. This standalone review does not test their combination or accept the broader tracking goal.
Evidence and limits

Reviewed head 881159057101c639504bd16d889c81cb5d514ee1; API base and actual main 663f3b327998526a13aa31e72ad729025c18983c; canonical source M 8daa93343cb7a33069b6c6b53a82eb4ec14941a0.

Independently fetched all 33 recorded upstream files at yuekaizhang/faster-cosyvoice@f1049c59196c2c1a890079abc56056b43f27cd1d, matched their UTF-8 byte lengths/Git blob identities to the readset and complete 117-entry tree, and checked the relevant technical and rights ranges. Checked the 87 changed paths, canonical/matrix additions and generated delta: M→H changes only 81 projection paths; 78 unrelated cards only replace the source pin. All 12 declared owner-resource SHA-256 values match actual H bytes; both applicability copies match the sidecar.

Hosted Python 3.11 checks: Ruff success; 3,544 passed / 13 skipped / 284 subtests. Actual checkout 866297f8c69267afd79fb38848a8fb6297df4387 merges this H into the assessed main and has zero file differences from H. Both installed-package checks succeeded. The per-head policy reports compliant for this exact H/main. Public current-H generator/read checks are attributed separately; I did not rerun them.

SkillEval remains PLANNED with zero comparisons/calls and an unsupported-snapshot limit; this is not efficacy evidence. No upstream tests, model/device/audio/service trial was run. This maintenance chat did not implement the change. The conclusion is a COMMENTED review, not a formal APPROVE, merge authorization or goal acceptance.

Copy link
Copy Markdown
Collaborator

Review at head 88115905: no defect found in the new Faster CosyVoice source record/reference in isolation (tools/build_skill_coverage.py --check passes locally), but I am not approving yet because of a cross-PR integration problem:

  1. Conflicts with the other open knowledge PRs: merging this head onto main together with any of Extend VLA observation-to-action benchmark guidance #342, knowledge: audit Infera serving-search result provenance #332, knowledge: validate NInfer state and completion contracts #325, knowledge: audit DeepSeek C expert-cache byte validity #324 or knowledge: distinguish Xe-Forge trial origin and timing #322 produces 81-85 conflicting files in my local trial merges (generated repo_packs/.../knowledge/**, docs/skill-coverage.md, docs/reference-matrix.md, docs/searchspace-matrix.md). Extend VLA observation-to-action benchmark guidance #342, knowledge: validate NInfer state and completion contracts #325 and knowledge: distinguish Xe-Forge trial origin and timing #322 also edit the same hand-written src/inferrsi/data/skill_library/methods/inference-benchmark-design/SKILL.md and metadata.json, so those need a real content merge, not only regeneration.
  2. Expected: please agree a merge order with the other authors; after each predecessor lands, rebase, re-merge inference-benchmark-design/SKILL.md/metadata.json, regenerate the projections from the new source revision and re-run the index/coverage checks, then request re-review on the new head.

Not verified by me: the upstream source pins/byte hashes in faster-cosyvoice-source.json.

Copy link
Copy Markdown
Collaborator

Re-review at head 881159057101c639504bd16d889c81cb5d514ee1 (range 663f3b327998526a13aa31e72ad729025c18983c...881159057101c639504bd16d889c81cb5d514ee1). Not approving.

No new commits since the prior short-SHA note. Isolation content (Faster CosyVoice reference) still looks coherent, but blockers remain:

  1. Dirty vs main: mergeable_state=dirty; current main is 1246348f252dbc7e473efb1752c2d81da15e23fd (ahead of this PR's base). Rebase required.
  2. Cross-PR integration: sibling knowledge PRs still open (Extend VLA observation-to-action benchmark guidance #342, knowledge: audit Infera serving-search result provenance #332, knowledge: validate NInfer state and completion contracts #325, knowledge: audit DeepSeek C expert-cache byte validity #324, knowledge: distinguish Xe-Forge trial origin and timing #322). Overlap on generated projections and matrix/coverage docs. Extend VLA observation-to-action benchmark guidance #342/knowledge: validate NInfer state and completion contracts #325/knowledge: distinguish Xe-Forge trial origin and timing #322 also edit the same hand-written inference-benchmark-design/SKILL.md and metadata.json.
  3. Expected: agree a merge order; after each predecessor lands, rebase, re-merge SKILL/metadata, regenerate projections from the new source revision, re-run index/coverage checks, and request re-review on the new head.

Not verified by me: upstream source pins/byte hashes in faster-cosyvoice-source.json. Overall upstream rights remain UNKNOWN as the PR itself notes.

Reviewed commit: 881159057101c639504bd16d889c81cb5d514ee1.

Merge main after the earlier source PRs and the shared source snapshot
landed. Where this PR and main extend the same files, keep main's additions
first, then the Faster CosyVoice additions. Generated projections keep main's bytes
until they are regenerated from this commit.

Agent-assisted-by: Claude Code / claude-opus-5-5 [effort=xhigh] (author)
Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com>
Run main's writers on the committed combined source. Only the edited
owner's record, the shared source snapshot and the coverage view change.

Agent-assisted-by: Claude Code / claude-opus-5-5 [effort=xhigh] (author)
Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PR review verdict — PASS
Reviewed base 14fa1f578655bbdcd101b8c4235299fc3d8360d3 and head a0978f59a24115e60e894a4bfdd5f57ea3f37ddb. Full diff (previousHead unset).

Verified in this revision:

  • references/dependency-aware-tts-playout.md is source-derived candidate guidance for yuekaizhang/faster-cosyvoice@f1049c59196c2c1a890079abc56056b43f27cd1d. It keeps server route credit, client zero-buffer playback, same-session Mel dependence, cumulative vocoding, and token-derived versus delivered-audio denominators distinct. Cited line ranges fall inside the inspected ranges in references/faster-cosyvoice-source.json. Status stays candidate / empirical not_run / efficacy not_evaluated.
  • Overall source rights stay UNKNOWN. The source record keeps selected Apache-2.0 file headers (Alibaba flow.py and HiFT generator.py; NVIDIA flashinfer_dit.py and flashinfer_flow.py) and unresolved HiFT / Nari inheritance. The new reference is original analysis and immutable links.
  • The pin, 33-path readset, license string, and not_run caveat match across inference-benchmark-design/metadata.json, knowledge/common/skills/inference-benchmark-design.json (sources, limitations, and provenance readsets), docs/reference-matrix.md, and docs/searchspace-matrix.md. Searchspace adds methodology context only; the skill-coverage hardware N/A reason is unchanged. Coverage readset count moves from 11 to 13 with the two new provenance readsets. The skill-index registry hash is unchanged.

Not verified here: the 33 upstream blobs and tree a5950f9eaa500141d08c29e29dc24e8d1f313f00 were not re-fetched; python tools/build_skill_coverage.py --check was not run; projection source_files sha256 values and source_revision b2d62f8192903ab31f8e8828f4e630a1bec776b7 were not recomputed; tests and CI were not executed.

No blocking defect on this head. The source-only comment at 88115905 is an earlier author check and is not the evidence for this review.

@amy-why-3459 amy-why-3459 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Incremental review of 881159057101c639504bd16d889c81cb5d514ee1..a0978f59a24115e60e894a4bfdd5f57ea3f37ddb (merge of main 14fa1f578655bbdcd101b8c4235299fc3d8360d3 in b2d62f81, then projection regeneration in a0978f59).

Verified:

  • The earlier blockers are resolved: the PR is now mergeable (clean) against current main, and #322/#324/#325 have landed. The hand-written inference-benchmark-design/SKILL.md (+6) and metadata.json (+48) are purely additive on top of main; the only - lines are comma moves, so the NInfer and other main-side entries are preserved.
  • The diff against main shrank from the old 80+ regenerated files to 9 files; only inference-benchmark-design.json, _provenance.json and docs/skill-coverage.md change in the generated projection.
  • The source_files hashes in the regenerated inference-benchmark-design.json match the head bytes of SKILL.md, metadata.json, dependency-aware-tts-playout.md and faster-cosyvoice-source.json.
  • All checks are green on this head (declarations on its latest run, pr-references, full-check 3.10/3.11, installed-package 3.10/3.11).

Still not independently verified by me: the upstream byte hashes in faster-cosyvoice-source.json. Overall upstream rights stay UNKNOWN, as the PR itself states. #342 still edits the same inference-benchmark-design files and will need to rebase after this one.

@Dong1017

Copy link
Copy Markdown
Collaborator Author

@zengchuang-hw PTAL

@zengchuang-hw zengchuang-hw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PR review verdict — PASS

Reviewed base 14fa1f578655bbdcd101b8c4235299fc3d8360d3 and head a0978f59a24115e60e894a4bfdd5f57ea3f37ddb. Acting as the independent reviewer under zengchuang-hw's delegated review authority, responding to the review request. I did not implement this change.

This is my first substantive review of this PR: I examined the full nine-path diff against current main and reconciled the integration range 881159057101c639504bd16d889c81cb5d514ee1..a0978f59a24115e60e894a4bfdd5f57ea3f37ddb. Amy's previous review is the historical integration baseline, not my own earlier review.

Verified:

  • The hand-written changes preserve main's existing guidance and add the Faster CosyVoice method/reference without creating a runtime, hardware coverage or efficacy claim. The two new reference resources are byte-identical to 8811590. The combined-source commit b2d62f8 includes main 14fa1f5; b2d62f8→head changes only the owner projection, shared provenance and coverage view.
  • Independently retrieved all 33 pinned upstream files. Their connector blob identities and complete 117-entry tree sizes/identities match the readset. Traced the actual client PCM alignment/zero-buffer clock, server route credit and timer boundary, chunk planner, cross-session batch exclusion, cumulative Mel vocoding and offline token-duration accounting. These support the reference's distinctions; reported benchmark/quality results remain author reports.
  • Recomputed SHA-256 from the four changed owner-resource contents and matched the projection. Source metadata agrees between sidecar and generated record. The source has no repository-level license/notice path in the pinned tree; UNKNOWN rights and file-level exceptions remain explicit.
  • Read AGENTS, review/contribution/knowledge contracts and governing #91/#177 scope. Earlier integration conflicts are resolved for the assessed main. This does not validate a future combination with #342.

Checks and evidence:

  • Independently performed the source/tree identity, four SHA-256 and commit/tree comparisons above.
  • Inspected current-head hosted Ready checks: Python 3.10/3.11 full-check and installed-package checks plus pr-references succeeded. Read the Python 3.11 log: Ruff passed; 3,582 tests passed, 14 skipped and 286 subtests passed. Installed-wheel log reports 128 source-grounded records. Tested merge 1593af3 has exactly the same tree as this head (8899009dd667247e03a3c5f80366fd128a34c4fd).
  • Latest declaration run reports compliant for this exact head; an earlier declaration failure is superseded by that corrected evaluation. SkillEval execute is skipped and its plan remains unexecuted, not efficacy evidence.
  • I did not rerun the native generators or test suite locally, execute upstream tests, or run models/devices/audio/service benchmarks. Hosted evidence is attributed above, not presented as my local execution.

Blocking findings before approval: none for this bounded source-guidance delivery.
Nonblocking integration note: #342 still needs its own current-main reconciliation and evidence refresh. Approval is not whole-issue acceptance, source licensing clearance, measured efficacy or merge authorization.

@Dong1017
Dong1017 merged commit bd61d20 into InferMatrixLab:main Nov 10, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:knowledge Knowledge line: packs, skill library, knowledge admission bot-reviewed kind:docs Documentation and template delivery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants