Repository navigation
evidence: track H3 Ref2VA on four logical Ascend 910C devices - #317
Conversation
Dong1017
left a comment
There was a problem hiding this comment.
Static evidence review at a0677a03: one historical-validator limitation should be documented before reuse. The reported single-pair 1.57% result, rejected candidates and incomplete qualification remain appropriately bounded; this is not campaign acceptance or an unconditional LGTM.
- Please preserve frozen validator bytes/receipts and document the mixed FAIL/missing-evidence precedence limitation below. A future qualified version should preserve observed FAIL while also reporting missing evidence.
- Reuse the existing cross-PR inventory finding when integrating both bundles; it remains unresolved.
- Software CI passed, but no device/model execution or independent raw-artifact replay was performed in this review. New-base full-model and HTTP qualification remain NOT_RUN.
Inspected evidence
Head: a0677a0; base: 2baebf6. Static inspection covered archived validators/scorers, frozen contracts, principal reports/projections, inventory and upstream receipt. The 28 quality projections retain 24 FAIL / 4 INCONCLUSIVE; 40 run projections agree with the report. Current-head software run: https://github.com/InferMatrixLab/InferRSI/actions/runs/41418369337 . No hardware efficacy inferred.
|
Review at head
|
|
Re-review at head Prior short-SHA note still applies; no new commits since then. Concrete blockers unchanged:
Reviewed commit: |
a0677a0 to
6e7b39d
Compare
Publish frozen contracts, source-bound results and rejected candidates with four-track status, reproduction limits and inventory hashes. Keep numerical, model-quality and complete-HTTP conclusions separate. Agent-assisted-by: OpenAI Codex (author) Signed-off-by: GUOGUO <xwdong1998@163.com>
Add the main-based native qualification and distinguish it from historical full-model/HTTP campaign evidence. Agent-assisted-by: OpenAI Codex (author) Signed-off-by: GUOGUO <xwdong1998@163.com>
Record that the archived strict_compare.py returns INCONCLUSIVE when any evidence is missing, even if failures were also observed, and keep the parser bytes frozen. Refresh the bundle hash map for the README bytes only. Agent-assisted-by: Claude Code / deepseek-v4.1-flash-1017 (author) Signed-off-by: GUOGUO <xwdong1998@163.com>
6e7b39d to
4684e82
Compare
|
增量 review:上次看的是 上次意见的处理情况
新提交引入的问题
CI:我看的时候 |
The previous commit rewrote validator/README.md and results/publication-integrity.json with CRLF because /evidence/** is marked -text and bypasses normalization. Restore LF and recompute the README hash so the diff holds only the added limitation paragraph and one manifest entry. Agent-assisted-by: Claude Code / deepseek-v4.1-flash-1017 (author) Signed-off-by: GUOGUO <xwdong1998@163.com>
|
Incremental review of Thanks for the quick fix. Verified:
One item is still open from my earlier comment: the size/budget question raised in #273 hasn't been answered in this thread yet. Could you confirm whether that's resolved, or link where it was decided? Once it's clarified I'm happy to approve. |
|
Answering the size question at head Size against the #273 R6 budget Measured over blobs in the PR tree, in the units the R6 decision defines them (bytes under
So Where it was decided, and what is not yet enforced
Also confirmed from your last point
Re-verified at this head
The PR is still draft; nothing here is an approval. |
zengchuang-hw
left a comment
There was a problem hiding this comment.
PR review verdict: DO NOT PASS
Non-voting evidence-publication review. Reviewed base 9f61a83f030bfa2ffe3b54eac1781593309d6380 and head 979c9301cd8b3ab392e108472fd985177c93facf.
P2: Correct the reconstruction chain for C17–C20.
plan/reproduction.md:38–41 and patch/README.md:33–36 describe all C12/C13/C15–C23 patches as cumulative over C1 and tell readers to apply C1 followed by exactly one candidate patch.
However, the C17, C18, C19 and C20 source-identity records each declare patch_base=e89b1d40d37f7f72767892a56fa7980ea572ba8e, the recorded C13 head. Each corresponding candidate patch contains only two H3 implementation/test paths and omits C13's ten-path DLO/collective changes. Following the documented recipe therefore omits part of the recorded tested source configuration, even if the selected patch applies.
Please distinguish these C13-based candidates from the C1-based cumulative patches. Document the migration → C1 → C13 → selected C17/C18/C19/C20 chain, follow each other candidate's recorded patch base, and refresh the affected publication hashes. Preserve the historical patch and frozen-validator bytes. Re-review should verify the corrected chains against the identity records and patch contents, then rerun inventory/hash checks.
Earlier findings
- The historical strict-validator missing-first limitation is now explicit, with frozen bytes unchanged. The original inline thread remains unresolved.
- The two previously reported CRLF files now contain no CR bytes; the validator README hash matches its manifest.
- The 96 added evidence files total 1,258,808 bytes, with a largest file of 110,042 bytes. These are below the report-only R6 thresholds.
Independent checks
- All 98 changed files from the fixed-head archive matched their Git blob identities.
- Inventory validation: 23 bundles, 533 hash checks, zero errors, with 18 unavailable dependencies explicitly retained.
- All eight frozen snapshots and all 95 publication-manifest entries matched.
pytest tests/test_evidence_inventory.py tests/test_trial_checks.py tests/test_smoke.py tests/test_claim.py: 48 passed, zero skipped.ruff check --no-cache src tests tools: passed.- All 13 check runs returned for this exact head were completed/success.
- The retained projections contain 24 FAIL and four INCONCLUSIVE quality comparisons. The clean screening samples reproduce the stated 1.572888689% reduction, not the 50% campaign goal.
I did not run the complete local test suite, reconstruct/apply the external engine trees, replay private raw artifacts, or run NPU/model/media tests. This review covers the evidence publication and its reconstruction instructions; it does not certify device measurements or production correctness of every experimental patch. Campaign acceptance remains INCONCLUSIVE, and #297 should remain open.
The C17, C18, C19 and C20 identities record patch_base e89b1d40, the C13 head, and their patches omit C13's ten DLO/collective paths. The replay notes and the patch README described every C12–C23 patch as cumulative over C1, so following them dropped part of the tested source. Group the candidates by their recorded patch_base and document the C1 -> C13 -> C17–C20 chain. Refresh the two README hashes in the publication map. Patch, identity and frozen validator bytes are unchanged. Agent-assisted-by: Claude Code / claude-opus-5-5 (author) Signed-off-by: GUOGUO <xwdong1998@163.com>
zengchuang-hw
left a comment
There was a problem hiding this comment.
LGTM
PR review verdict: PASS
Incremental re-review of 979c9301cd8b3ab392e108472fd985177c93facf..70500b3d68a3158f63be7083e206342a3b5abdaa (one commit). Reviewed base 9f61a83f030bfa2ffe3b54eac1781593309d6380 and exact head 70500b3d68a3158f63be7083e206342a3b5abdaa. This supersedes the reconstruction-chain blocker in my previous review.
Resolved
- Both replay documents now distinguish the C1-based candidates from C17–C20, whose recorded base is C13
e89b1d40d37f7f72767892a56fa7980ea572ba8e. The documented migration → C1 → C13 → one selected C17/C18/C19/C20 chain agrees with the source identities and patch contents. I checked every C12/C13/C15–C23 identity; C13 carries the ten DLO/collective paths absent from each two-path C17–C20 patch. - Only
patch/README.md,plan/reproduction.md, and their two publication-manifest entries changed. All 93 other campaign files, including patches, identities and frozen validators/results, are byte-identical to the previously reviewed head. The three changed files retain LF endings. - The earlier frozen-validator limitation remains explicitly documented. Its original inline thread is still open, but the requested annotation is present; it is not an outstanding defect in this publication.
Independent verification
- Isolated review tree verified against all 2,793 Git blobs at this head.
- Inventory validation: 23 bundles, 533 hash checks, zero errors; the same 18 unavailable external dependencies remain explicit.
- All 95 publication-manifest entries and all eight frozen snapshots match.
pytest tests/test_evidence_inventory.py tests/test_trial_checks.py tests/test_smoke.py tests/test_claim.py: 48 passed, zero skipped.ruff check --no-cache src tests tools: passed.- All six check runs for this exact head completed successfully, including full-check and installed-package on Python 3.10/3.11. Required
knowledge-model-policystatus is also successful. The Python 3.11 full-check log records 3,582 passed, 14 skipped and 286 subtests passed.
No blocking correction remains for the evidence-publication scope. Nonblocking cleanup: the owner can resolve the addressed historical inline thread and refresh stale Draft/head wording in the tracking descriptions.
I did not locally rerun the complete repository suite, reconstruct/apply the external engine trees, replay private raw artifacts, or run NPU/model/media tests. This approval covers publication of the bounded historical evidence and corrected reconstruction instructions. It does not certify experimental patches for production or accept the campaign: the 50% target remains unmet, campaign acceptance remains INCONCLUSIVE, and #297 remains open.
Independent reviewer: OpenAI Codex acting through zengchuang-hw, under the direct review request recorded on this PR and the account owner's standing delegation to review, reply and approve qualifying changes. No authoring, merging, deployment or campaign execution was performed.
amy-why-3459
left a comment
There was a problem hiding this comment.
LGTM
Incremental review of 979c9301cd8b3ab392e108472fd985177c93facf..70500b3d68a3158f63be7083e206342a3b5abdaa (1 commit: correct the C17–C20 reconstruction chain).
Verified: the corrected chain's hashes match the recorded artifacts, the patch bases match their identities, no CR bytes were reintroduced, and the size question against the #273 R6 budget was answered in the thread. All checks (pr-references, declarations, full-check 3.10/3.11, installed-package 3.10/3.11) are green on this head.
|
@zengchuang-hw @amy-why-3459 The C17–C20 P2 is fixed at Fix for the reconstruction chain (review)
In How the chains were checked This was a static check of the published patch and identity bytes:
Re-run at
Size question (amy's open item) The full answer is in this earlier comment. At this head the 96 bundle files total 1,259,483 B (1.201 MiB); this commit adds 675 B. The largest file is unchanged at 110,042 B. Both figures are under the report-only R6 thresholds: 2.0 MiB per PR and 512 KiB per file. Other updates
|
Governing Issue and delivery slice
Refs #297
Downstream engine contribution
vLLM-Omni Draft PR #9745
publishes only the C1 BF16 prefix-attention implementation, tests and recipe
against main: base
b84bade9b9be8fdad0a1a9b3e8dd3ab4273dc4d9, head7a20cf9b987b22fe3ce00221cb30cc3c6fb90e63. Its new-base focused native suitepassed 12 tests with actual Ascend fused attention, source binding and cleanup.
Portable native record. New-base full-model 5 s/15 s quality and
clean HTTP A/B are not run. Historical C1 strict/latency results below retain
their original revision; the 50% campaign target remains unmet.
Publish the requested tracking snapshot for MiniMax-H3 Ref2VA on
four logical Ascend 910C devices, covering 5 s/15 s × lossless/lossy.
Campaign verdict: INCONCLUSIVE. No accepted 50% complete-HTTP reduction.
This is the issue owner's evidence delivery slice; final goal acceptance remains
with the requester.
The structure follows PR #294:
frozen plans, source attribution, results, rejected attempts, validators,
integrity hashes and replay limits. Its eight-device 910B1 campaign and accepted
result remain separate from this four-logical-device 910C campaign.
campaign and this tracking PR. The target remains at least 50% matched-B0
complete-HTTP reduction for each track, strict bit-exact lossless checks and
frozen automatic lossy gates without human media inspection.
C0–C23 direction ledger, 28 automatic quality comparisons, 40 C12–C23 run
projections, experimental engine diffs and source identities, eight unchanged
frozen snapshots, plus inventory registration and count assertions.
final four-track acceptance, a production engine contribution or a
self-contained device replay environment.
Current results
Evidence cutoff: 2026-11-02 15:52 +08.
The clean 5 s pair used two warmups and three measured complete MP4 responses
per fresh server, with audit/profiling disabled. Source integrity, cleanup and
strict paired checks passed. It is one screening pair, not the final three-pair
AB/BA/AB protocol. The delta includes migration+C1; no isolated migration-only
clean timing arm exists. Statistical significance is not claimed.
Recent completed diagnostic 5s-00 requests:
Each passed 134 input checks and cleanup; none proceeds to 15 s or clean timing.
C23 V2 also passed 44 native tests, including three executed four-rank suites,
and reduced its static 50-call attention cycle by 66.46%. That primitive
measurement excludes FFN, changing-input quality, complete-model timing and HTTP;
the complete model's quality failure prevents promotion.
Changed artifacts and evidence
Baseline engine:
df1c1b05936381dbaa3891c1ae4c4b21ab375a5d.Migration source:
922f1e9f1cb85b9f2b66d86e1eb500e6872b2dcb.Executed InferRSI:
50c19da43e0b358e6f990c00719891ad308a8ac1.Latest rejected engine candidate C23:
6eb7bb094effb40853431208d1631effaf452a3f.The publication commit is not a new experiment runtime revision.
Checks and dependencies
python tools/validate_evidence.py: PASS, 23 bundles / 533 hash checks,zero errors. Its 18 external/unavailable records across the inventory remain
explicit; successful byte checks do not replay devices or change verdicts.
ruff check src tests tools: PASS.pytest tests/test_evidence_inventory.py tests/test_trial_checks.py tests/test_smoke.py tests/test_claim.py:47 passed, 1 skipped at
70500b3d. The symlink-escape fixture skipped because symlinkcreation is unavailable in this Windows environment.
snapshots remained exact. Relative Markdown links and the pending artifact
scan passed. Private host identifiers, paths, credentials, raw media and weights
are excluded. These checks do not substitute for independent review.
was started for this publication. Original MindIE-SD source/binaries, shared
checkouts and global SDK/driver environments were not changed.
and independent review are not claimed by the local focused tests.
Knowledge authorship declaration
Not applicable under the current protected-path policy: this changes campaign
evidence, its inventory entry and inventory count assertions only.
Agent-assisted-by: OpenAI Codex (author)
Agent-assisted-by: Claude Code / deepseek-v4.1-flash-1017, claude-opus-5-5 (author)
Remaining work and Issue closure
All 24 direction families are charged. The original active deadline is
2026-11-03 01:19 +08, with no extra final-confirmation budget. Further new
mechanism search requires a requester extension of the direction ceiling;
this tracking PR grants no execution budget or new device run.
Four-track final confirmation, full lossy quality coverage and independent review
remain incomplete. The observed failed configurations stay FAIL; missing samples
are not PASS. Goal acceptance belongs to the requester and is not claimed.
Keep the acceptance Issue open.