Skip to content

fix: bound admission writer queue and rejected status retries - #204

Merged
Dong1017 merged 5 commits into
mainfrom
fix/admission-writer-queue-validation
Oct 28, 2026
Merged

Dong1017 merged 5 commits into
mainfrom
fix/admission-writer-queue-validation

Conversation

@Dong1017

@Dong1017 Dong1017 commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Governing Issue and delivery slice

Refs #203

Owner requested a bounded temporary fix without using occupied local agents. Implemented in an isolated cloud checkout at base 505231ee8cc9991c086e683627309cd6df2e2005; head 681d60971483239d3e2d3e06ee208a0c281a43e1.

  • Preserve one status writer; use bounded queue: max rather than replacing the single pending job. Up to 100 jobs wait; this is not event deduplication or unlimited capacity.
  • Classify HTTP 422 status POST rejection as an execution error, terminal only for this invocation. Explicit server capacity response remains separate from unknown validation rejection. No guessed 900-status limit.
  • Cover invalidation, history fallback, reserve and final-verdict writes; keep old remote success/pending uncertainty explicit. Same-run carry revalidates premises; changed heads/new invocations retry.
  • Add fixed allowlisted diagnostic resource/field/code values and complete-history count, without raw response text or secrets.
flowchart LR
 A[Eligible events] --> B[One writer with bounded queue]
 B --> C[Status POST]
 C --> D[Success: normal assessment]
 C --> E[422: honest error and diagnostics]
 E --> F[No identical replay in this invocation]
Loading

Verification

  • Focused policy suites: 181 passed, 65 subtests passed.
  • Independent read-only review of all five changed files: no actionable blocker; separately ran nine new rejection/plan tests and thirteen HTTP tests, all passed.
  • Ruff (src tests tools) and git diff --check: passed.
  • Published five-file tree compared byte-for-byte with the locally reviewed files: identical.
  • Full software suite completed successfully in the isolated cloud environment after local package installation (1407 collected tests; skips remain). Initial attempt lacked package installation for subprocess tests and started before the final mock-compatibility adjustment; the successful rerun uses the final published file tree.
  • Hosted CI and live queue/publication behavior: pending.

Scope and remaining work

This is a partial corrective delivery, not closure of #203. Historical unknown 422 server causes and affected remote-state recovery still need fresh safe diagnostics. No real status POST experiment, workflow dispatch, settings/credential change, model/GPU call or paid experiment was performed. Existing red/cancelled runs are not relabeled. Global writer errors remain failures; a successful trigger projection is not global acceptance.

Only control/workflow/docs/tests paths changed; no protected knowledge content, model allowlist, admission exception or required-check change. Agent-assisted software implementation and independent review are recorded above; no unverified model-setting declaration is fabricated.

Goal ready for acceptance: No; keep #203 open pending live verification.

Signed-off-by: X. DONG <xwdong1998@gmail.com>
Agent-assisted-by: OpenAI Codex
Signed-off-by: X. DONG <xwdong1998@gmail.com>
Agent-assisted-by: OpenAI Codex
Signed-off-by: X. DONG <xwdong1998@gmail.com>
Agent-assisted-by: OpenAI Codex
Signed-off-by: X. DONG <xwdong1998@gmail.com>
Agent-assisted-by: OpenAI Codex
Signed-off-by: X. DONG <xwdong1998@gmail.com>
Agent-assisted-by: OpenAI Codex
@Dong1017
Dong1017 marked this pull request as ready for review October 28, 2026 03:23
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T03:25:22.537295Z 681d609 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Dong1017 Dong1017 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent delegated review of the temporary corrective slice: LGTM for the code, head 681d60971483239d3e2d3e06ee208a0c281a43e1, base 505231ee8cc9991c086e683627309cd6df2e2005. The reviewer inspected all five files without editing them and independently ran nine new rejection/plan tests plus thirteen HTTP tests; no actionable blocker found. Parent integration additionally verified the remote file tree matches that reviewed locally.

Ready 40626431740: all four full-check/installed-package jobs pass. Focused policy suite: 181 passed + 65 subtests; full local software suite completed successfully after package installation; Ruff and whitespace checks pass. Latest admission refresh is still pending at this posting: merge remains conditional on its successful current-head result.

flowchart LR
 A[Single writer preserved] --> B[Bounded pending queue]
 C[422 POST rejection] --> D[Execution error with safe diagnostics]
 D --> E[No same-invocation replay]
 B --> F[Live behavior still to verify]
 E --> F
Loading

No false compliance or claimed remote invalidation: old success/pending may remain when GitHub rejects a write. New invocations recheck; unknown 422 is not capacity evidence. Queueing has a 100-pending bound and does not deduplicate work. Live queue and historical 422 recovery remain unverified, so #203 stays open. No model/hardware efficacy or automatic issue acceptance is implied.

@Dong1017
Dong1017 merged commit 0f85fa8 into main Oct 28, 2026
8 of 13 checks passed
@Dong1017
Dong1017 deleted the fix/admission-writer-queue-validation branch October 30, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant