Repository navigation
feat: add model-aware engine research and full-pipeline preparation - #106
Closed
david6666666 wants to merge 1 commit into
Closed
david6666666 wants to merge 1 commit into
david6666666 wants to merge 1 commit into
Conversation
Broaden opt-in research discovery across model, framework, task, modality and mechanism queries while preserving exact catalog search and filters. Document native-reference selection and complete H3 weight, quantization and target-memory preparation with pinned sources and unverified hardware scope. Agent-assisted-by: Codex / gpt-6.1-sol [effort=max] (author) Signed-off-by: David Chen <530634352@qq.com>
david6666666
marked this pull request as ready for review
October 23, 2026 02:50
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by the requested split: #110 — h3.c repository knowledge (merged first) and #111 — generic research framework (second). Neither replacement includes the excluded plan document. This combined PR is closed without merging.
Governing Issue and delivery slice
Refs #103
knowledge searchANDs all query tokens, so concatenating a model, framework, diffusion and video can hide transferable knowledge. This adds opt-inknowledge research: separate model/framework/task/modality/mechanism queries, a bounded deduplicated union, and per-result query attribution. Existing exact search and package filters retain their contracts.The requesting owner explicitly authorized these code/workflow changes and a PR. This slice also updates the canonical engine-research procedure with eligible native-reference selection, complete component accounting, compatible quantization/engine pairs and conditional hardware decisions. It does not implement an H3 engine or Metal runtime, download model payloads, or claim target performance/quality acceptance.
Knowledge authorship declaration
Changed artifacts and evidence
research.py, public CLI, packaged H3 profileChecks and dependencies
Tested content:
f804ec1503e977787c572d5d27d1f3258017b01f; assessed base:9e20eb7226de49f7368c4a24599f9ccf11ccda3c.ruff check src tests tools; router skill validation;git diff --check.wheel[skills]installation,tests/check_installed.pywith-Ioutside the checkout, and the actual installed console command. The profile, procedure, worked example and inventory are present.test_unreadable_process_table_fails_before_launchfailure mocks Linux on Windows, whereos.getpgrpis absent; the implementer reproduced the same failure at the unchanged base. The test and process implementation are unchanged. This is not a local full-suite pass. The initial unconfigured run was 580 passed / 12 failed / 14 skipped.Remaining work and Issue closure
The preparation slice is implemented and independently reviewed; current CI must be checked before readiness. Mac execution, media quality and target-memory qualification remain work for a separately frozen campaign. Goal acceptance and Issue closure remain with the requesting owner/maintainers; this PR uses a non-closing reference and does not claim campaign PASS.