Skip to content

Repository navigation

feat(api): api update #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
increase-releases wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(api): api update #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .stats.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
configured_endpoints: 255
openapi_spec_hash: 31dbb51b621eeb3886e4e430fe825146
openapi_spec_hash: 3bad89eb4727f4d7be689c8e34092360
config_hash: de151ebd21a0bd391662389b310a8f49
6 changes: 3 additions & 3 deletions lib/increase/models/ach_transfer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,8 @@ class ACHTransfer < Increase::Internal::Type::BaseModel
# @!attribute statement_descriptor
# The descriptor that will show on the recipient's bank statement.
#
# @return [String]
required :statement_descriptor, String
# @return [String, nil]
required :statement_descriptor, String, nil?: true

# @!attribute status
# The lifecycle status of the transfer.
Expand Down Expand Up @@ -362,7 +362,7 @@ class ACHTransfer < Increase::Internal::Type::BaseModel
# [Standard Entry Class (SEC) code](/documentation/ach-standard-entry-class-codes)
# to use for the transfer.
#
# @param statement_descriptor [String] The descriptor that will show on the recipient's bank statement.
# @param statement_descriptor [String, nil] The descriptor that will show on the recipient's bank statement.
#
# @param status [Symbol, Increase::Models::ACHTransfer::Status] The lifecycle status of the transfer.
#
Expand Down
6 changes: 3 additions & 3 deletions lib/increase/models/transaction.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1129,8 +1129,8 @@ class ACHTransferIntention < Increase::Internal::Type::BaseModel
# @!attribute statement_descriptor
# A description set when the ACH Transfer was created.
#
# @return [String]
required :statement_descriptor, String
# @return [String, nil]
required :statement_descriptor, String, nil?: true

# @!attribute transfer_id
# The identifier of the ACH Transfer that led to this Transaction.
Expand All @@ -1154,7 +1154,7 @@ class ACHTransferIntention < Increase::Internal::Type::BaseModel
# The American Bankers' Association (ABA) Routing Transit Number (RTN) for the
# destination account.
#
# @param statement_descriptor [String] A description set when the ACH Transfer was created.
# @param statement_descriptor [String, nil] A description set when the ACH Transfer was created.
#
# @param transfer_id [String] The identifier of the ACH Transfer that led to this Transaction.
end
Expand Down
6 changes: 3 additions & 3 deletions rbi/increase/models/ach_transfer.rbi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ module Increase
attr_accessor :standard_entry_class_code

# The descriptor that will show on the recipient's bank statement.
sig { returns(String) }
sig { returns(T.nilable(String)) }
attr_accessor :statement_descriptor

# The lifecycle status of the transfer.
Expand Down Expand Up @@ -295,7 +295,7 @@ module Increase
settlement: T.nilable(Increase::ACHTransfer::Settlement::OrHash),
standard_entry_class_code:
Increase::ACHTransfer::StandardEntryClassCode::OrSymbol,
statement_descriptor: String,
statement_descriptor: T.nilable(String),
status: Increase::ACHTransfer::Status::OrSymbol,
submission: T.nilable(Increase::ACHTransfer::Submission::OrHash),
transaction_id: T.nilable(String),
Expand Down Expand Up @@ -446,7 +446,7 @@ module Increase
settlement: T.nilable(Increase::ACHTransfer::Settlement),
standard_entry_class_code:
Increase::ACHTransfer::StandardEntryClassCode::TaggedSymbol,
statement_descriptor: String,
statement_descriptor: T.nilable(String),
status: Increase::ACHTransfer::Status::TaggedSymbol,
submission: T.nilable(Increase::ACHTransfer::Submission),
transaction_id: T.nilable(String),
Expand Down
6 changes: 3 additions & 3 deletions rbi/increase/models/transaction.rbi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2010,7 +2010,7 @@ module Increase
attr_accessor :routing_number

# A description set when the ACH Transfer was created.
sig { returns(String) }
sig { returns(T.nilable(String)) }
attr_accessor :statement_descriptor

# The identifier of the ACH Transfer that led to this Transaction.
Expand All @@ -2026,7 +2026,7 @@ module Increase
account_number: String,
amount: Integer,
routing_number: String,
statement_descriptor: String,
statement_descriptor: T.nilable(String),
transfer_id: String
).returns(T.attached_class)
end
Expand All @@ -2052,7 +2052,7 @@ module Increase
account_number: String,
amount: Integer,
routing_number: String,
statement_descriptor: String,
statement_descriptor: T.nilable(String),
transfer_id: String
}
)
Expand Down
2 changes: 1 addition & 1 deletion scripts/mock
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions sig/increase/models/ach_transfer.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ module Increase
routing_number: String,
settlement: Increase::ACHTransfer::Settlement?,
standard_entry_class_code: Increase::Models::ACHTransfer::standard_entry_class_code,
statement_descriptor: String,
statement_descriptor: String?,
status: Increase::Models::ACHTransfer::status,
submission: Increase::ACHTransfer::Submission?,
transaction_id: String?,
Expand Down Expand Up @@ -103,7 +103,7 @@ module Increase

attr_accessor standard_entry_class_code: Increase::Models::ACHTransfer::standard_entry_class_code

attr_accessor statement_descriptor: String
attr_accessor statement_descriptor: String?

attr_accessor status: Increase::Models::ACHTransfer::status

Expand Down Expand Up @@ -145,7 +145,7 @@ module Increase
routing_number: String,
settlement: Increase::ACHTransfer::Settlement?,
standard_entry_class_code: Increase::Models::ACHTransfer::standard_entry_class_code,
statement_descriptor: String,
statement_descriptor: String?,
status: Increase::Models::ACHTransfer::status,
submission: Increase::ACHTransfer::Submission?,
transaction_id: String?,
Expand Down Expand Up @@ -184,7 +184,7 @@ module Increase
routing_number: String,
settlement: Increase::ACHTransfer::Settlement?,
standard_entry_class_code: Increase::Models::ACHTransfer::standard_entry_class_code,
statement_descriptor: String,
statement_descriptor: String?,
status: Increase::Models::ACHTransfer::status,
submission: Increase::ACHTransfer::Submission?,
transaction_id: String?,
Expand Down
8 changes: 4 additions & 4 deletions sig/increase/models/transaction.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ module Increase
account_number: String,
amount: Integer,
routing_number: String,
statement_descriptor: String,
statement_descriptor: String?,
transfer_id: String
}

Expand All @@ -578,23 +578,23 @@ module Increase

attr_accessor routing_number: String

attr_accessor statement_descriptor: String
attr_accessor statement_descriptor: String?

attr_accessor transfer_id: String

def initialize: (
account_number: String,
amount: Integer,
routing_number: String,
statement_descriptor: String,
statement_descriptor: String?,
transfer_id: String
) -> void

def to_hash: -> {
account_number: String,
amount: Integer,
routing_number: String,
statement_descriptor: String,
statement_descriptor: String?,
transfer_id: String
}
end
Expand Down
10 changes: 5 additions & 5 deletions test/increase/resources/ach_transfers_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def test_create_required_params
routing_number: String,
settlement: Increase::ACHTransfer::Settlement | nil,
standard_entry_class_code: Increase::ACHTransfer::StandardEntryClassCode,
statement_descriptor: String,
statement_descriptor: String | nil,
status: Increase::ACHTransfer::Status,
submission: Increase::ACHTransfer::Submission | nil,
transaction_id: String | nil,
Expand Down Expand Up @@ -97,7 +97,7 @@ def test_retrieve
routing_number: String,
settlement: Increase::ACHTransfer::Settlement | nil,
standard_entry_class_code: Increase::ACHTransfer::StandardEntryClassCode,
statement_descriptor: String,
statement_descriptor: String | nil,
status: Increase::ACHTransfer::Status,
submission: Increase::ACHTransfer::Submission | nil,
transaction_id: String | nil,
Expand Down Expand Up @@ -153,7 +153,7 @@ def test_list
routing_number: String,
settlement: Increase::ACHTransfer::Settlement | nil,
standard_entry_class_code: Increase::ACHTransfer::StandardEntryClassCode,
statement_descriptor: String,
statement_descriptor: String | nil,
status: Increase::ACHTransfer::Status,
submission: Increase::ACHTransfer::Submission | nil,
transaction_id: String | nil,
Expand Down Expand Up @@ -202,7 +202,7 @@ def test_approve
routing_number: String,
settlement: Increase::ACHTransfer::Settlement | nil,
standard_entry_class_code: Increase::ACHTransfer::StandardEntryClassCode,
statement_descriptor: String,
statement_descriptor: String | nil,
status: Increase::ACHTransfer::Status,
submission: Increase::ACHTransfer::Submission | nil,
transaction_id: String | nil,
Expand Down Expand Up @@ -251,7 +251,7 @@ def test_cancel
routing_number: String,
settlement: Increase::ACHTransfer::Settlement | nil,
standard_entry_class_code: Increase::ACHTransfer::StandardEntryClassCode,
statement_descriptor: String,
statement_descriptor: String | nil,
status: Increase::ACHTransfer::Status,
submission: Increase::ACHTransfer::Submission | nil,
transaction_id: String | nil,
Expand Down
10 changes: 5 additions & 5 deletions test/increase/resources/simulations/ach_transfers_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def test_acknowledge
routing_number: String,
settlement: Increase::ACHTransfer::Settlement | nil,
standard_entry_class_code: Increase::ACHTransfer::StandardEntryClassCode,
statement_descriptor: String,
statement_descriptor: String | nil,
status: Increase::ACHTransfer::Status,
submission: Increase::ACHTransfer::Submission | nil,
transaction_id: String | nil,
Expand Down Expand Up @@ -93,7 +93,7 @@ def test_create_notification_of_change
routing_number: String,
settlement: Increase::ACHTransfer::Settlement | nil,
standard_entry_class_code: Increase::ACHTransfer::StandardEntryClassCode,
statement_descriptor: String,
statement_descriptor: String | nil,
status: Increase::ACHTransfer::Status,
submission: Increase::ACHTransfer::Submission | nil,
transaction_id: String | nil,
Expand Down Expand Up @@ -142,7 +142,7 @@ def test_return_
routing_number: String,
settlement: Increase::ACHTransfer::Settlement | nil,
standard_entry_class_code: Increase::ACHTransfer::StandardEntryClassCode,
statement_descriptor: String,
statement_descriptor: String | nil,
status: Increase::ACHTransfer::Status,
submission: Increase::ACHTransfer::Submission | nil,
transaction_id: String | nil,
Expand Down Expand Up @@ -191,7 +191,7 @@ def test_settle
routing_number: String,
settlement: Increase::ACHTransfer::Settlement | nil,
standard_entry_class_code: Increase::ACHTransfer::StandardEntryClassCode,
statement_descriptor: String,
statement_descriptor: String | nil,
status: Increase::ACHTransfer::Status,
submission: Increase::ACHTransfer::Submission | nil,
transaction_id: String | nil,
Expand Down Expand Up @@ -240,7 +240,7 @@ def test_submit
routing_number: String,
settlement: Increase::ACHTransfer::Settlement | nil,
standard_entry_class_code: Increase::ACHTransfer::StandardEntryClassCode,
statement_descriptor: String,
statement_descriptor: String | nil,
status: Increase::ACHTransfer::Status,
submission: Increase::ACHTransfer::Submission | nil,
transaction_id: String | nil,
Expand Down
Loading