Skip to content
This repository was archived by the owner on Mar 29, 2021. It is now read-only.
This repository was archived by the owner on Mar 29, 2021. It is now read-only.

Massive performance problems of the Tiers tab #260

Closed

Description

@Ardenian

I noticed there is quite a problem with performance when using the Tiers tab to search for tiers of a raid. When starting to enter something into the bossname field, the performance goes down to nothing.
When the raid is found, as example entering 'horth' for Horthania, it throws 1000 and 200 error messages of type:
[IDotDS] TypeError: idrinth.tier[listKey] is undefined

The first time one tries to open the tierbox of the raid ( in this example Horthania), it throws 100 errors of the same type as above and the tierbox won't show up.
Afterwards, next tries, it will always show up properly without error message.

Entering 'horg' for Horgrak will throw lots of errors like:

[IDotDS] TypeError: idrinth.tier.list[listKey].epics[difficulty] is undefined  Ardenian:1358:9
[IDotDS] TypeError: idrinth.tier[listKey] is undefined

and Hiorgrak won't show up as raid boss in the Tiers tab.

When entering a single character, like 'a', the browser will freeze and Firefox will ask you eventually whether it should stop the script.

Activity

  1. Idrinth commented on Jan 26, 2017

    @Idrinth
    Member

    performance might be related to the way we search - guess that might need a rework

  2. Ardenian commented on Jan 27, 2017

    @Ardenian
    ContributorAuthor

    Maybe removing the auto-search on entering something into the textfield and instead adding a button to click or pressing 'enter' to activate the search will fix the performance issue.

  3. Idrinth commented on Jan 27, 2017

    @Idrinth
    Member

    uses the same resources, issues here is single-threads, see #265 for a solution ;)

  4. added a commit that references this issue on Jan 28, 2017
    c2edf84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions