Skip to content
This repository was archived by the owner on Mar 29, 2021. It is now read-only.
This repository was archived by the owner on Mar 29, 2021. It is now read-only.

Fix automatic adding of magic images #163

Open

Description

@Idrinth

5PG seems to use even more broken image naming now - more images slip through.

Activity

  1. self-assigned this
    on Sep 30, 2016
  2. changed the title [-]Fix automatic adding of magic imaged[/-] [+]Fix automatic adding of magic imageds[/+] on Sep 30, 2016
  3. changed the title [-]Fix automatic adding of magic imageds[/-] [+]Fix automatic adding of magic images[/+] on Sep 30, 2016
  4. added this to the High effort expected milestone on Oct 3, 2016
  5. Ardenian commented on Oct 3, 2016

    @Ardenian
    Contributor

    One could, if the 5PG images cannot be loaded, externally load them from the dotd wikia, as second option.
    Alternatively, one could also think about storing them manually externally in some kind of data storage, since they are less likely to change whereas there might come new issues from 5PG in the future.

  6. Idrinth commented on Oct 3, 2016

    @Idrinth
    MemberAuthor

    It's more of a naming issue, the api doesn't provide the correct names for the images :(

  7. Ardenian commented on Oct 12, 2016

    @Ardenian
    Contributor

    Something that will hapen with everything they change. They change something and over here something gets broken. Might be ways to prevent that, though externalizing the magic images might be one easy way, considerng they aren't file-size heavy either.

  8. Idrinth commented on Oct 12, 2016

    @Idrinth
    MemberAuthor

    would need the correct name for those as well then - if I don't find them where I expected them...

  9. Ardenian commented on Oct 12, 2016

    @Ardenian
    Contributor

    Well, since you could name the images the way you want it would offer the advantage to be independent form their naming, though having to organize everything yourself.

  10. Idrinth commented on Oct 12, 2016

    @Idrinth
    MemberAuthor

    I still need the source image to be found, ardenian, we are storing them locally once we found them, so they won't be requested from 5pg in any case.

  11. Theodotosp commented on Oct 12, 2016

    @Theodotosp
    Collaborator

    Do you need help on finding with this issue?

  12. Idrinth commented on Oct 12, 2016

    @Idrinth
    MemberAuthor

    No, but thanks @Theodotosp , I just need to find the time to write the code to read the game's xml

  13. Ardenian commented on Oct 12, 2016

    @Ardenian
    Contributor

    Ahh, I see. Well, dotd wikia might be an addition to get the images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions