Repository navigation
Conversation
|
Postindustria (IAB Tech Lab member). @aleksUIX, the arithmetic matches our fee-basis revision on #94. Four fixes so the texts agree:
Analyzed and generated with the help of Claude, fully reviewed by me. |
|
Updated in response to these four points. Zero-rate units commitments now work; spend still requires a positive agreed rate. Added fee-inclusive minimum-spend and minimum-budget cases: 400,000 impressions at USD 25 CPM plus USD 1,500 totals USD 11,500, passing 11,000 and failing 12,000. All 60 calculation vectors pass, along with the appendix and YAML checks. The calculator remains a limited discussion profile; it does not establish acceptance or implement tax-inclusive arithmetic. |
|
Postindustria (IAB Tech Lab member). @aleksUIX, our pricing PR merges this PR and changes the adapter, vectors, and discussion document:
The discussion document keeps three proposals: no second charge for a cost in the unit rate, the sign rules, and the rounding limit. Could you review the merge there? Open questions, also open questions 1 and 2 on our pricing PR:
Analyzed and generated with the help of Claude, fully reviewed by me. |
|
Reviewed the merge at e484091. Your list matches what the adapter and vectors do, and § 5.6.5 carries the fee arithmetic as #117 had it. All 60 vectors, Two stale spots in the discussion document: the
`agreed_rate` MUST NOT be negative. When `commitment.basis` is `spend`, on an
entry other than `FLAT` or `TIME`, `agreed_rate` MUST be greater than 0.
I'll keep #117 as a draft until #146 lands and won't push to its branch. |
|
Thanks, @aleksUIX. #146 takes all of it, so you can check it there:
Analyzed and generated with the help of Claude, fully reviewed by me. |
#94 treats
pricing[]as alternatives, while #115 adds seller fees as extra rows and leavesderived_unitsunchanged. At USD 25 CPM, a USD 50,000 commitment containing a USD 2,500 fee leaves USD 47,500 for media, or 1.9 million impressions.This adds discussion wording and 60 fixed calculation vectors.
amountuses the same terms asagreed_rate, without choosing gross or net commission treatment or settling #115's tax question. Selected flat charges contribute once and cannot be separate pricing alternatives. Spend requires a positive agreed rate; units commitments permit a zero rate. Minimum-spend and budget bounds include flat charges.The supporting calculator preserves an explicitly accepted counter below a posted floor and returns
floor_check: not_checked. Passing arithmetic does not establish seller acceptance, reserve inventory or authorize a commitment. Tax-inclusive arithmetic, print adjustments and general mandatory-fee structures remain outside this profile.The normative spec and field indexes are unchanged. If the wording is adopted, the affected body, appendix and example updates should land together.
Validation: 60 vectors, existing appendix checks and 11 YAML files pass. Three added zero-rate cases fail against the prior published calculator and pass with this change.
Member of the IAB Tech Lab Agentic Taskforce, commenting in a personal capacity.