You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Incorrect version reported for Aoe_TemplateHints module #78
The latest version of the Aoe_Templatehints module is 0.4.3 (according toe the config.xml), but the hypernode:modules:list-updates command outputs the following:
+-------------------+-----------+-----------------+----------------+--------+--------------------------+
| Name | Code pool | Current version | Latest version | Status | Newer version available? |
+-------------------+-----------+-----------------+----------------+--------+--------------------------+
| Aoe_TemplateHints | community | 0.4.3 | 0.6.0 | active | Yes |
+-------------------+-----------+-----------------+----------------+--------+--------------------------+
The reason why this happens is because Byte 'crowd-sources' the version numbers by parsing all app/etc/modules/*.xml files. If somebody forks an extension and keeps the name but ups the version number, this will create a false positive.
Maybe Byte can implement a mechanism that filters out version numbers that only occur once across all codebases?
I've manually set this one back to 0.4.3 for now, that should remove the false positive temporary. but yes we should definitely make something to make this less error-prone
Activity
peterjaap commentedon Jun 8, 2018
The reason why this happens is because Byte 'crowd-sources' the version numbers by parsing all
app/etc/modules/*.xmlfiles. If somebody forks an extension and keeps the name but ups the version number, this will create a false positive.Maybe Byte can implement a mechanism that filters out version numbers that only occur once across all codebases?
vdloo commentedon Jun 8, 2018
related code:
https://github.com/Hypernode/tools.hypernode.com/blob/master/views/modules.py#L45
vdloo commentedon Jun 8, 2018
I've manually set this one back to 0.4.3 for now, that should remove the false positive temporary. but yes we should definitely make something to make this less error-prone
aadmathijssen commentedon Jun 8, 2018
Nice, thanks for the quick reply, guys!