Repository navigation
Improve configuration - #147
Conversation
DON'T automagically create local.json Remove redundancy in config/
Remove obvious documentation
* Start and configure processes in with NODE_ENV in package.json * Remove obsolete step definitions
If you don't have a background process for mongo, how much of an effort is it to open a terminal?
The script was assuming a POSIX shell and a command `ifconfig` available on the system. I don't have either. I guess we can just remove it. You can access the server from the local network if you override `host` in your `config/local.json`. This is much better in my opinion.
|
I'm currently testing maildev. Is it possible that this is never API/server/services/admin/admin.class.js Line 141 in fcf5353 |
appinteractive
left a comment
appinteractive
left a comment
There was a problem hiding this comment.
can be merged after re-adding dev:local
| "start": "concurrently 'mongod' 'wait-on tcp:27017 && cross-env NODE_ENV=production node server/'", | ||
| "dev:debug": "npm run clear && concurrently '$npm_package_config_mongoDev &>/dev/null' 'wait-on tcp:27017 && cross-env DEBUG=feathers && cross-env NODE_ENV=development nodemon --inspect server/'", | ||
| "dev": "npm run clear && concurrently '$npm_package_config_mongoDev &>/dev/null' 'wait-on tcp:27017 && cross-env DEBUG=feathers && cross-env NODE_ENV=development nodemon server/'", | ||
| "dev:local": "sh scripts/run-local.sh", |
There was a problem hiding this comment.
could you please re-add the dev:local command for mobile development?
There was a problem hiding this comment.
The script uses ifconfig to set some environment variables with the local IP address. E.g. I don't have ifconfig installed and the script fails silently. I find it much more convenient to set host in config/local.json to the local ip and just run yarn run dev. Can we keep scripts/run-local.sh deleted, please?
There was a problem hiding this comment.
I can add some instructions in README.md if you like.
There was a problem hiding this comment.
You missed the point of that script I think. It is getting your host ip to then start the app in your local network so you can access it from your mobile phone. It’s way more convenient then to write your ip into the local.config
But for me it’s fine to put it into the readme.
|
good work! |
This line is set to true by an api call while importing invited users via thre WebApp. You can choose to send those mails or not in the process. |
|
@appinteractive bump |
I had a moment of 'a-ha!' after reading through: https://github.com/lorenwest/node-config/wiki/Configuration-Files
The goal of this PR is to improve the configuration and remove redundancy. And I really dislike magic generation of configuration files. That was confusing me a while ago.
mongoserver is not runningyarn run clearbeforemocha