Repository navigation
Correct how the orphan cost is sized — interval + lag, not interval - #101
Merged
Merged
Conversation
…not interval The '~9.5% of fleet throughput' figure in the README, the config description and the module comment was derived by dividing ~40,400 schedule rows by the nominal 6h catalog interval and comparing that to the throughput ceiling. That assumes the orphans achieve their nominal cadence, which a backlogged queue cannot give them. nextRenderTime is stamped at COMPLETION, so a row rendered L behind its due time has its next render set interval after that: the realized cycle is interval + L, and the lag is carried into every subsequent cycle rather than caught up. At the 8.2h lag measured on that cluster, orphans on a 6h interval ran a ~14h cycle — ~2,900 renders/hr, ~4% of the 71,289/hr ceiling, roughly half what was claimed. The ceiling is also the wrong denominator while the fleet is saturated. Against the work it is actually completing, with every class stretched by the same interval + L, the orphans were ~8% — which is the figure that describes what deleting them frees, and it is why the sweep is still worth running. Documents the interval + lag model itself in all three places, since dividing rows by interval is the natural way to size this and it is wrong whenever there is a backlog.
There was a problem hiding this comment.
Code Review
This pull request updates the documentation and comments in README.md, configSchema.js, and orphanSweep.js to provide a more precise calculation of the throughput cost of orphan schedule rows. It explains that because nextRenderTime is stamped at completion, any lag L extends the cycle to interval + L, revising the previous flat estimate of ~9.5% throughput to ~4% of the throughput ceiling or ~8% of actual completed work under saturation. There are no review comments, and I have no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs and comments only; no behavior change. Corrects a number I introduced in #100.
The error
The
~9.5% of fleet throughputfigure in the README, therender.orphanSweepdescription and theorphanSweep.jsmodule comment came from~40,400 schedule rows ÷ 6h nominal interval = ~6,740/hragainst the 71,289/hr ceiling.That assumes the orphans achieve their nominal 6h cadence. A backlogged queue cannot give them that — and this cluster was ~8.2h behind.
The model
nextRenderTimeis stamped at completion, not at the original due time. So a row renderedLbehind its due time has its next render setintervalafter that: the realized cycle isinterval + L, and the lag is carried into every subsequent cycle rather than caught up.At
L ≈ 8.2h, orphans on a 6h interval run a ~14h cycle:Roughly half what was stated.
But the ceiling is the wrong denominator anyway
While the fleet is saturated, what matters is the orphans' share of the work actually being completed. Stretching every class by the same
interval + L(PDP 48+8.2 ≈ 56h, catalog 6+8.2 ≈ 14h):So the original figure was roughly right for share of work being done, but reached by the wrong route and stated against the wrong denominator. 8% is what deleting them frees, and the benefit compounds slightly: removing that work shortens
L, which shortensinterval + Lfor every remaining class.All three sites now document the
interval + lagmodel itself, not just the corrected number — dividing rows by interval is the natural way to size this, and it's wrong whenever there's a backlog.664 tests passing, lint and format clean.