Repository navigation
Restore the project .env CLI flow on the Fabric and Learn pages - #801
Conversation
harper#4039 reverts the CLI refusal of a project .env target or credential, so undo what documentation#796 changed on the two pages that stayed in this repo: the safe-deployments guide again pins the target in .env and copies it into the staged deploy directory, and the Fabric page again says harper login appends HARPER_CLI_TARGET to an existing .env. Two corrections beyond the revert: the append also skips when the environment sets a target, and the credential warning names the primary HARPER_CLI_USERNAME/HARPER_CLI_PASSWORD variables. Dispatch-Task: docs-harper-revert-4001 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dispatch-Task: docs-harper-revert-4001 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dispatch-Task: docs-harper-revert-4001 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request updates the documentation to reflect changes in how the Harper CLI handles target configuration, transitioning from shell environment variables to utilizing a local .env file. It explains the automatic appending of HARPER_CLI_TARGET during login, details the loading behavior during deployment, and warns against storing sensitive credentials in .env because it is uploaded to all nodes. The review feedback recommends splitting a security warning regarding credentials and deployment uploads into separate sentences to improve readability and emphasize the warning.
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-801 This preview will update automatically when you push new commits. |
Dispatch-Task: docs-harper-revert-4001 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-801 This preview will update automatically when you push new commits. |
🧹 Preview CleanupThe preview deployment for this PR has been removed. |
⊙ Problem
Revert the CLI refusal of a project .env (harper#4039) lets a project
.envconfigure theharperCLI again, as in v5.3. Two pages here still describe the refusal from documentation#796: they tell readers to removeHARPER_CLI_TARGETfrom.envand say the CLI stops with an error.💡 Solution
.env, logs in with bareharper login, and copies.envinto the staged deploy directory.harper loginappendsHARPER_CLI_TARGETto an existing.env.HARPER_CLI_USERNAMEandHARPER_CLI_PASSWORD. Shipping the staged.envis called harmless only while it holds just the target.🤔 Merge after the live reference drops the refusal
The site uses harper's docs at harper-pro
main'scorepointer, which today carries the refusal.Depends-onholds this PR until harper#4039 merges. Merging before harper-pro updatescoreto include it leaves the guide and reference in conflict. Check withnode scripts/assemble-content.mjs --sources.🔧 Changes
fabric/cluster-creation-management.md: removes the refusal and its#project-env-fileslink, an anchor harper#4039 deletes; keeps "saves the URL as the CLI's default target"; restores the.envappend sentence, namingHARPER_CLI_TARGETandCLI_TARGETin the file or the environment as the conditions that skip it. Look hardest here: it is the one sentence that is not a plain revert.learn/administration/safe-deployments-and-rollback.mdx: restores the pre-Document the CLI refusing a project .env target or credential #796 "Log in" section, with its credential warning now naming the primary variables; thecp .env deploy/.envstaging step and its conditional "harmless" note; and the "load-balanced cluster URL in.env" wording.✅ Verification
392a82d. The login prompt defaults to the.envtarget (bin/login.ts:22,52-56). The append is skipped when the file or environment setsHARPER_CLI_TARGETorCLI_TARGET(bin/login.ts:152-165). Every command loads.envwithout overriding the shell (bin/cliOperations.ts:948). Login saveslast_target(bin/cliCredentials.ts:111).HARPER_DOCS_PATH=<harper#4039 docs> npm run build: passes. The assembled authentication page has no refusal section, and the build logged no broken links or anchors.npm run format:check: clean.Depends-on: harper#4039
🤖 Generated by Anthropic Claude (Opus 5.5); posted via @kriszyp.
Related PRs: #796 overlaps (this reverts its changes to both pages)
Complexity: easy
Deferred findings
ecc7a9a3914ba23aminor documentation —learn/administration/safe-deployments-and-rollback.mdx— Learn page restores .env target flow while assembled v5 reference may still describe the 5.4 refusal until harper#4039 reaches harper-pro's — NOT FILEDOrigin — the dispatch brief this PR was written from
Undo the CLI .env refusal on the learn and fabric pages
Docs pages in HarperFast/documentation still describe a CLI refusal that is being reverted.
HarperFast/harper#4039 reverts the part of HarperFast/harper#4001 that made the harper CLI refuse a project .env setting its target or credentials. A project .env can configure the CLI again, as in v5.3.
harper loginagain appends HARPER_CLI_TARGET to an existing .env, using the URL the client connected to.#796 documented the refusal. Its reference/ pages and release notes moved into HarperFast/harper's docs/ and are handled by #4039. Two pages stayed in this repo and need the #796 changes undone: fabric/cluster-creation-management.md and learn/administration/safe-deployments-and-rollback.mdx (restore the .env-based flow and remove "From v5.4.0, the CLI stops with an error").
Wait until HarperFast/harper#4039 is merged before opening for review; if it is closed unmerged, stop and report that.
Dispatch: task
docs-harper-revert-4001· queued by task:release-cut-main-5.4.0-beta.1 · ran by claude/opus/xhigh · worker kzyp-xps-1Review-Coverage: authored=claude; ran=gemini,cursor-composer,codex; adjudicated=domain; declined=cursor-grok,muse; rounds=4; full=1 @ fc3b8b6
Review-Attention: skim ~2m (decisions: env-file-target-vs-shell-export, exact-revert-vs-corrected-revert) @ fc3b8b6