Skip to content

refactor: 重构 DataPack - #6982

Open
fishdry1000 wants to merge 21 commits into
HMCL-dev:mainfrom
fishdry1000:work/refactor-datapack-from-main
Open

fishdry1000 wants to merge 21 commits into
HMCL-dev:mainfrom
fishdry1000:work/refactor-datapack-from-main

Conversation

@fishdry1000

@fishdry1000 fishdry1000 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

DataPack 其实是 DataPackManager
Pack 其实是 DataPackFile
思考ing

修改

现在 DataPackManager 像 LocalAddonManager

LocalAddonManager 之于 DefaultGameInstance
≈
DataPackManager 之于 World

重命名

DataPack -> DataPackManager
DataPack.Pack -> DataPackFile

拆分

DataPack.Pack 内部类 -> DataPackFile

@github-actions github-actions Bot added the 100+ label Oct 14, 2026
@fishdry1000 fishdry1000 changed the title refactor: 重构 DataPack.Pack refactor: 重构 DataPack Oct 15, 2026
…ack-from-main

# Conflicts:
#	HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/DataPackListPage.java
#	HMCLCore/src/main/java/org/jackhuang/hmcl/addon/datapack/DataPack.java
@github-actions github-actions Bot added 500+ and removed 100+ labels Oct 17, 2026
@fishdry1000
fishdry1000 requested a review from Glavo October 17, 2026 05:43

@Glavo Glavo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本审查建议由 GPT-6 Astra 生成


已将具体审查建议标注在对应代码行。

@fishdry1000
fishdry1000 requested a review from Glavo October 22, 2026 14:07

@Glavo Glavo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本审查建议由 GPT-6 Astra 生成


已将具体审查建议标注在对应代码行。

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Static analysis found the following issues (max count 10):

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Static analysis found the following issues (max count 10):

@fishdry1000
fishdry1000 requested a review from Glavo October 26, 2026 15:52

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants