Repository navigation
refactor: 重构 DataPack - #6982
Open
fishdry1000 wants to merge 21 commits into
Open
fishdry1000 wants to merge 21 commits into
fishdry1000 wants to merge 21 commits into
Conversation
Glavo
reviewed
Oct 16, 2026
…ack-from-main # Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/DataPackListPage.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/datapack/DataPack.java
… DataPack.Pack 为 DataPackFile 类
Glavo
reviewed
Oct 20, 2026
Glavo
left a comment
Member
There was a problem hiding this comment.
本审查建议由 GPT-6 Astra 生成
已将具体审查建议标注在对应代码行。
Glavo
reviewed
Oct 26, 2026
Glavo
left a comment
Member
There was a problem hiding this comment.
本审查建议由 GPT-6 Astra 生成
已将具体审查建议标注在对应代码行。
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataPack 其实是 DataPackManager
Pack 其实是 DataPackFile
思考ing
修改
现在 DataPackManager 像 LocalAddonManager
LocalAddonManager 之于 DefaultGameInstance
≈
DataPackManager 之于 World
重命名
DataPack -> DataPackManager
DataPack.Pack -> DataPackFile
拆分
DataPack.Pack 内部类 -> DataPackFile