Skip to content

fix: remap duplicate graph edges to final node - #29

Draft
dajiaohuang wants to merge 1 commit into
Graphicle-AI:mainfrom
dajiaohuang:w18/graphicle-dedup-transitive-main
Draft

dajiaohuang wants to merge 1 commit into
Graphicle-AI:mainfrom
dajiaohuang:w18/graphicle-dedup-transitive-main

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

Summary

  • Keep node alias remaps pointed at the final canonical ID when repeated duplicate labels successively select shorter IDs.
  • Add a regression test for edges that previously remained attached to a removed intermediate node ID.

Validation

  • cargo test --lib edge_aliases_follow_repeatedly_replaced_canonical_id — passed on current main base e4437fc3c9769a5f8983e811b04b84b3c9288d66.
  • rustfmt --edition 2024 --check crates/graphicle-graph/src/build_normalize.rs — passed.
  • git diff --check origin/main...HEAD — passed.

Signed-off-by: dajiaohuang <mikewushuwen@outlook.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant