Repository navigation
Hash global graph inputs in bounded chunks - #28
Draft
dajiaohuang wants to merge 1 commit into
Draft
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Signed-off-by: dajiaohuang <mikewushuwen@outlook.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GlobalStore::addhashes a graph source before the configured graph-size check runs during parsing.file_hashusedfs::read, temporarily allocating the complete source file even when the import is later rejected for exceeding the cap.Hash the file in fixed 64 KiB chunks, preserving the existing first-16-hex SHA-256 key. Retry interrupted reads and propagate other I/O errors. Add a multi-chunk Rust regression and an independent SHA-256 comparison to the Graphify parity harness.
Verification
cargo fmt --check: passed.file_hashRust test: passed.postgres,bedrock,transcriptionfeature Clippy could not compile because this environment has no OpenSSL development installation (openssl-sysfailure).reference/Graphify-Labs__graphify-0.9.95source directory is absent in this checkout.No dependency changes. CI was not queried.