Skip to content

Fix partial passage coverage reporting - #24

Draft
dajiaohuang wants to merge 1 commit into
Graphicle-AI:mainfrom
dajiaohuang:w18/chunks-partial-coverage-label
Draft

dajiaohuang wants to merge 1 commit into
Graphicle-AI:mainfrom
dajiaohuang:w18/chunks-partial-coverage-label

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

Change

When max_passages cuts off a document after keeping one or more of its passages, chunks increments omitted_documents but did not include that document in the set used to classify omitted_documents_are. This could report oldest even though the cut document is both kept and omitted. Include the cut document in the omitted set and add a regression test for the reported coverage.

Also use ? for the existing optional Go import parse branch so strict Clippy passes for graphicle-memory.

Validation

  • cargo fmt --check
  • cargo test --locked --all-targets in crates/graphicle-memory
  • cargo clippy --locked --all-targets -- -D warnings in crates/graphicle-memory
  • git diff --check

Signed-off-by: dajiaohuang <mikewushuwen@outlook.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant