Repository navigation
Fix partial passage coverage reporting - #24
Draft
dajiaohuang wants to merge 1 commit into
Draft
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Signed-off-by: dajiaohuang <mikewushuwen@outlook.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
When
max_passagescuts off a document after keeping one or more of its passages,chunksincrementsomitted_documentsbut did not include that document in the set used to classifyomitted_documents_are. This could reportoldesteven though the cut document is both kept and omitted. Include the cut document in the omitted set and add a regression test for the reported coverage.Also use
?for the existing optional Go import parse branch so strict Clippy passes forgraphicle-memory.Validation
cargo fmt --checkcargo test --locked --all-targetsincrates/graphicle-memorycargo clippy --locked --all-targets -- -D warningsincrates/graphicle-memorygit diff --check