Repository navigation
Fix Python SDK Windows session lookup - #20
Closed
dajiaohuang wants to merge 1 commit into
Closed
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Signed-off-by: dajiaohuang <mikewushuwen@outlook.com>
Member
|
Thank you, Wu. This shipped in 0.1.14 as your commit, with your authorship and sign-off kept, plus one small follow-up so a Windows machine with no home folder falls back to the current folder exactly as the program does. The CHANGELOG credits you. Closing this PR as landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client.from_session()to the native Windows data directory,%LOCALAPPDATA%\Graphicle, with the native home-directory fallback whenLOCALAPPDATAis missing or relative.Validation
py -3 -m unittest discover -s sdk/python/tests -t sdk/python -v— 2 tests passed.git diff --cached --check— passed before commit.This PR is Draft for review. Existing PR #19 remains with its current owner.