Skip to content

fix: Makes isTypeOf mutable - #189

Merged
NeedleInAJayStack merged 1 commit into
GraphQLSwift:mainfrom
NeedleInAJayStack:fix/mutable-isTypeOf
Nov 15, 2026
Merged

NeedleInAJayStack merged 1 commit into
GraphQLSwift:mainfrom
NeedleInAJayStack:fix/mutable-isTypeOf

Conversation

@NeedleInAJayStack

Copy link
Copy Markdown
Member

This allows overriding of isTypeOf after the schema has been created, but before execution. This is necessarily to customize object isTypeOf on SDL-parsed schemas.

@GNMoseke GNMoseke left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one I understand!

NeedleInAJayStack added a commit to GraphQLSwift/graphql-generator that referenced this pull request Nov 15, 2026
This fixes an issue where, when a Union was returned, the underlying GraphQL executor couldn't find the concrete type (and therefore concrete type resolver), resulting in a runtime `Could not find a resolve function` error. Depends on GraphQLSwift/GraphQL#189
This allows overriding of `isTypeOf` after the schema has been created, but before execution. This is necessarily to customize object `isTypeOf` on SDL-parsed schemas.
@NeedleInAJayStack

Copy link
Copy Markdown
Member Author

Benchmarks indicate no significant performance change.

@NeedleInAJayStack
NeedleInAJayStack merged commit d45529c into GraphQLSwift:main Nov 15, 2026
7 of 8 checks passed
NeedleInAJayStack added a commit to GraphQLSwift/graphql-generator that referenced this pull request Nov 15, 2026
This fixes an issue where, when a Union was returned, the underlying GraphQL executor couldn't find the concrete type (and therefore concrete type resolver), resulting in a runtime `Could not find a resolve function` error. Depends on GraphQLSwift/GraphQL#189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants