[willfarrell]

See https://docs.npmjs.com/cli/v6/configuring-npm/package-json#files for details. Every little bit to improve cold start times.

[medikoo]

@willfarrell great thanks for that.

Still, we'd prefer to go with .npmignore. From my experience using files can lead to errors (e.g. one may forget to add file to files while adding file to the package), and currently we do not have automated validation of npm packaging prior deployment, so such error if happens is not easily discoverable.

[willfarrell]

No problem, I've updated to .npmignore.

PS there might be value in updating the license file to match LICENSE (a whitelisted value) and more likely to be caught by license scanners.

[medikoo]

@willfarrell thanks for update! Please see my comments

PS there might be value in updating the license file to match LICENSE

It was just addressed with #47

[medikoo]

This file is unconditionally included in npm package, let's remove it from here

[willfarrell]

Sure, although I it may need to be renamed to README.md. Like me to take care fo that?

[medikoo]

That's good idea, thanks!

[medikoo]

Let's ensure EOL at EOF

[willfarrell]

I"ll make it so

[medikoo]

Thank you!

[G-Rath]

@medikoo would it be possible to publish a new version to release these and other changes?

The current version of querystring includes a number of tmp files as well as what's covered by .npmignore:

./querystring/.History.md.un~
./querystring/.package.json.un~
./querystring/.Readme.md.un~
./querystring/.travis.yml
./querystring/decode.js
./querystring/encode.js
./querystring/index.js
./querystring/package.json
./querystring/test/.index.js.un~
./querystring/test/common-index.js
./querystring/test/index.js
./querystring/test/tap-index.js

[medikoo]

@G-Rath just published v0.2.1