Repository navigation
Inconsistencies with node core #6
Description
- In node 0.11,
optionscan include adecodeURIComponentorencodeURIComponentproperty. See: https://github.com/joyent/node/blob/master/lib/querystring.js#L180 - The encode/decode functions should be overridable via
querystring.escapeandquerystring.unescape, see: http://nodejs.org/api/querystring.html#querystring_querystring_escape
Activity
add escape/unescape per http://nodejs.org/api/querystring.html, fix for
Gozala commentedon Feb 27, 2015
@medikoo is maintaining this repo, so I don't want to make API changes without him being ok with that. I think work that @feross is doing is very important & it would be a shame if do not support him, regardless of our API preferences.
feross commentedon Feb 27, 2015
Thanks @Gozala :)
The goal of this module is to match the node/iojs
querystringmodule, right? Seems like API changes shouldn't be debated in this repo, but in the node/iojs projects before API changes are made. Once node/iojs commit to an API, the module ought to just mirror it :) At least, that's what I do inbuffer.medikoo commentedon Mar 1, 2015
@Gozala this can't be reliable achieved without getting back to single module version. I'm fine with this, as in my work I rely more on querystring2 package.
If you're also ok with it, in some free moment I can make it so it's single module with latest node.js implementation.
philipwalton commentedon Apr 2, 2015
I just encountered this issue and completely agree with @feross.
If you're not going to match the API exactly, at a bare minimum the differences should be documented. As it is today I had to read through the code to see if my implementation was buggy or if this library just didn't support this option.
Gozala commentedon Apr 2, 2015
@medikoo sure let's merge with your querystring2 if resolves this issue for everyone.
emilbayes commentedon Sep 26, 2015
Any progress on this?
Browserify seems to rely on the module by default, so it's a shame that it's not 1:1 with Node coreMy bad, the browserify README.md links to this module, but the package.json specifiesquerystring-es3Merge changes from Trott/querystring
medikoo commentedon Apr 11, 2017
Should be addressed with #20 it covers also ES3 version, PR's are very welcome (and I will handle them promptly).