Skip to content

Quickstart tests - #569

Merged
theacodes merged 3 commits into
masterfrom
quickstart-tests
Oct 12, 2016
Merged

theacodes merged 3 commits into
masterfrom
quickstart-tests

Conversation

@theacodes

Copy link
Copy Markdown
Contributor

No description provided.

Jon Wayne Parrott added 2 commits October 11, 2016 14:06
Change-Id: I5f01ec8003b9a9daf16e75119c048556e14afe42
Change-Id: Id6ba9d8e4fd3229e05b1c5a57b2cd3518350224d
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2016

@pytest.fixture
def mock_client(cloud_config):
original_client_ctor = translate.Client

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's a ctor?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constructor.

Comment thread vision/cloud-client/quickstart.py Outdated
image = vision_client.image(content=image_file.read())
with io.open(file_name, 'rb') as image_file:
content = image_file.read()
import pdb; pdb.set_trace()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks vestigial

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeedly-doo. Fixed.

Change-Id: I5e259a0fe1864bcd65deb4cdeedb0d938b218ae4
@theacodes theacodes mentioned this pull request Oct 12, 2016
@theacodes

Copy link
Copy Markdown
Contributor Author

I'm merging this, if anyone has concerns I'll address them in a follow up PR.

@theacodes
theacodes merged commit 4c639cc into master Oct 12, 2016
@theacodes
theacodes deleted the quickstart-tests branch October 12, 2016 17:48
@jerjou

jerjou commented Oct 12, 2016

Copy link
Copy Markdown
Contributor

LGTM

busunkim96 pushed a commit to busunkim96/python-vision that referenced this pull request May 20, 2020
* Add tests for quickstarts
* Update secrets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants