Skip to content

Cloud Run tests are throwing lint errors #7787

Closed
Closed
Cloud Run tests are throwing lint errors#7787
Assignees
glasnt
Labels
api: runIssues related to the Cloud Run API.samplesIssues that are directly related to samples.type: cleanupAn internal cleanup or hygiene concern.

Description

@leahecole
leahecole
opened on Apr 12, 2022

run/idp-sql and run/deployment-previews are throwing lint errors - PTAL and correct, or, if we cannot specify a more specific type, exempt the line from lint checking and add a justification in the comment

cc @GoogleCloudPlatform/aap-dpes

Activity

  1. leahecole
    added
    type: cleanupAn internal cleanup or hygiene concern.
    api: runIssues related to the Cloud Run API.
    on Apr 12, 2022
  2. leahecole
    assigned
    glasnt
    on Apr 12, 2022
  3. product-auto-label
    added
    samplesIssues that are directly related to samples.
    on Apr 12, 2022

  4. glasnt commented on Apr 12, 2022

    @glasnt
    glasnt
    on Apr 12, 2022
    Contributor

    This is being addressed in #7779 for django/idp. The deployment previews one may be fixed by the same flake8-annotations update, but it might require more work.

  5. glasnt commented on May 3, 2022

    @glasnt
    glasnt
    on May 3, 2022
    Contributor

    This should now be resolved for both, via #7779 and #7789

  6. glasnt
    closed this as completedon May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: runIssues related to the Cloud Run API.samplesIssues that are directly related to samples.type: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions