Switch functions tests to Python 3.6+ #3341

Activity

1. kurtisvg

   added

   type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.

   on Apr 10, 2020
2. kurtisvg

   self-assigned this

   on Apr 10, 2020
3. tmatsuo commented on May 15, 2020

   

   tmatsuo

   on May 15, 2020

   Contributor

   More actions

   Here is the permalink:

   python-docs-samples/.kokoro/tests/run_tests.sh

   Lines 89 to 97 in 07bc5fc

   	# Skip unsupported Python versions for Cloud Functions
   	# (Some GCF samples' dependencies don't support them)
   	if [[ "$file" == "functions/"* ]]; then
   	PYTHON_VERSION="$(python --version 2>&1)"
   	if [[ "$PYTHON_VERSION" == "Python 2."* || "$PYTHON_VERSION" == "Python 3.5"* ]]; then
   	# echo -e "\n Skipping $file: Python $PYTHON_VERSION is not supported by Cloud Functions.\n"
   	continue
   	fi
   	fi

   @kurtisvg
   I'm not sure it's still relevant. The bash script is excluding python 2.x and python 3.5? We don't have python 3.5 any more iirc.
4. tmatsuo commented on May 15, 2020

   

   tmatsuo

   on May 15, 2020

   Contributor

   More actions

   Maybe I'll try to remove that block and run the periodic build to see how it goes.
5. kurtisvg commented on May 15, 2020

   

   kurtisvg

   on May 15, 2020

   ContributorAuthor

   More actions

   SGTM
6. tmatsuo

   added a commit that references this issue on May 15, 2020

   cleanup: remove stale code block

   ...

   This issue will close once commit a8b336b is merged into the 'master' branch.

   a8b336b
7. busunkim96

   closed this as completedin #3767on May 15, 2020
8. busunkim96

   added a commit that references this issue on May 15, 2020

   cleanup: remove stale code block (#3767)

   ...

   This issue will close once commit bf73da5 is merged into the 'main' branch.

   bf73da5