Skip to content

Missing CI/CD and tests for contributed code in AutoML/census_income_prediction #2380

Closed

Description

@gguuss

It looks like someone is circumventing our style checks and avoiding contributing tests by putting code in Jupyter notebooks.

See this PR for additional details regarding the missing tests for AutoML/census_income_prediction. For all functions within the code, there should be an accompanying test and the contributed Python should meet the style standards for our repo.

There are definitely errors in the code that would be caught by lint, for example, most of the code uses 2 spaces where there should be 4 for indentations. Another example, on lines 288-289, it looks like the import order is wrong. There are probably a lot more but it's difficult to tell with the code obfuscated within Jupyter markdown.

Activity

  1. andrewferlitsch commented on Oct 7, 2019

    @andrewferlitsch
    Contributor

    @sirtorry Can you take a look at this issue.

  2. sirtorry commented on Oct 7, 2019

    @sirtorry
    Contributor

    Working on it this week.

  3. added
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    and removed
    🚨This issue needs some love.
    triage meI really want to be triaged.
    on Nov 15, 2019
  4. andrewferlitsch commented on Dec 2, 2019

    @andrewferlitsch
    Contributor

    @sirtorry Any update on the issue?

  5. czahedi commented on Jan 15, 2020

    @czahedi
    Contributor

    Hi Torry, gentle reminder ping about this issue. Thanks!

  6. sirtorry commented on Jan 16, 2020

    @sirtorry
    Contributor

    This quarter, we'll be introducing a notebook creation process that will address testing. At which point, we'll resolve this issue.

  7. added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    and removed
    🚨This issue needs some love.
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    on Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.api: automlIssues related to the AutoML API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions