Repository navigation
Gateways: Confusing output for list_devices_for_gateway #1997
Description
The list_devices_for_gateway function in gateway/gateway.py has a loop that isn't exercised which results in confusing output. There is no 'deviceNumIds' key in the devices dict .
In this example 'my-node-device' is bound to gateway 'testgateway'
$ python gateway.py --service_account_json XYZ.json --registry_id=my-registry --device_id=null --gateway_id=testgateway --project_id=myproject list_devices_for_gateway
Device: 2587394384972593 : my-node-device
No devices bound to gateway testgateway
The dict at devices dict is missing 'deviceNumIds'
{u'devices': [{u'numId': u'2587394384972593', u'id': u'my-node-device'}]}
Metadata
Metadata
Assignees
Labels
No labels
Activity
gguuss commentedon Jun 12, 2019
Thanks for the heads up, what version of Python are you using? I just tested the sample and I'm seeing the following output for a gateway with no bound devices:?
A gateway with one bound device renders as:
A gateway with two bound devices renders as:
gguuss commentedon Jun 12, 2019
I see what you're saying though, I'm not sure what conditions the sample is trying to resolve with the second loop or why/when the deviceNumIds dict would be populated. I'll take another look later on.
gguuss commentedon Aug 7, 2019
Resolved in this PR. As you pointed out, the initial check for
deviceNumIdswould never be reached.