Skip to content

Gateways: make the --device_id parameter required only for commands that need it #1996

Closed
Closed
Gateways: make the --device_id parameter required only for commands that need it#1996
Assignees
gguuss

Description

@stevebriskin
stevebriskin
opened on Feb 5, 2019

https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/iot/api-client/beta-features/gateway/gateway.py#L597 requires the --device_id for all invocations but some calls ( list_devices_for_gateway and list_gateways) do not need it.

Activity

  1. gguuss commented on May 15, 2019

    @gguuss
    gguuss
    on May 15, 2019
    Contributor

    We could probably benefit from refactoring the commands all at once as there are more than just the device ID that should be optional.

  2. gguuss
    self-assigned this
    on May 15, 2019

  3. gguuss commented on Aug 7, 2019

    @gguuss
    gguuss
    on Aug 7, 2019
    Contributor

    Should be resolved once we've merged this PR.

  4. gguuss
    closed this as completedon Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions