Repository navigation
[FIrestore Samples] Update tests to be self-contained and verified for correctness. #1788
Description
In which file did you encounter the issue?
Describe the issue
Tests aren't self contained and also not being verified for correctness. At the moment, tests only run the samples and verify that they execute without failure. Although, tests do provide some level of support using this method, they aren't verifying state correctness of Firestore post after testing a given sample.
Activity
gguuss commentedon Oct 10, 2019
This may be fixed in the updated tests from @BenWhitehead.
BenWhitehead commentedon Oct 11, 2019
There are a few older tests that need to have assertions added to them.
crwilcox commentedon Dec 31, 2019
@BenWhitehead do we have the individual tests we should fix?
BenWhitehead commentedon Jan 2, 2020
@crwilcox I think with your updated bootstrapping for the tests that should hopefully transparently take care of this.
@frankyn Do you have specific tests that we should double check to make sure the fix from @crwilcox addresses things?
andrewferlitsch commentedon Mar 16, 2020
@crwilcox PTAL
frankyn commentedon Mar 17, 2020
Apologies, I missed this in email.
The tests are not validating correctness and only making sure samples execute without failures.
Here's an example of a test being verified: https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/firestore/cloud-client/snippets_test.py#L74-L80
Here's an example of test not being verified: https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/firestore/cloud-client/snippets_test.py#L70-L71
leahecole commentedon May 14, 2020
I've been in touch with @BenWhitehead recently, and it is still in the pipeline.
meredithslota commentedon Mar 7, 2023
A partial fix was implemented in #2667 but work remains (see last comment from @frankyn).