dev_appserver.py doesn't ignore directories indicated in --watcher_ignore_re and skip_files

There are reports that --watcher_ignore_re and skip_files do not have any effect.

The case:

python-compat-runtime/appengine-compat/exported_appengine_sdk/google/appengine/tools/devappserver2/watcher_common.py

Lines 71 to 74 in 743ade7

    
           def ignore_dir(dirpath, dirname, skip_files_re): 
        
             """Report whether a directory should not be watched.""" 
        
             return (dirname.startswith(_IGNORED_PREFIX) or 
        
                     skip_files_re and skip_files_re.match(os.path.join(dirpath, dirname)))

os.path.join(dirpath, dirname) returns an absolute path.
skip_files_re.match compares from the begging
match seem always return False

I observed that function

python-compat-runtime/appengine-compat/exported_appengine_sdk/google/appengine/tools/devappserver2/watcher_common.py

Lines 78 to 90 in 743ade7

    
           def skip_ignored_dirs(dirpath, dirnames, skip_files_re=None): 
        
             """Skip directories that should not be watched. 
        
             Args: 
        
               dirpath: the prefix of absolute paths to dirnames. 
        
               dirnames: a list of directories. e.g: we have two directories: 
        
                 '/tmp/foo/a.txt', '/tmp/foo/b.txt', then: 
        
                 dirpath = '/tmp/foo', dirnames = ['a.txt', 'b.txt'] 
        
               skip_files_re: a regular_expression, absolute paths matching it are 
        
                 skippable. 
        
             """ 
        
             _remove_pred(dirnames, lambda d: ignore_dir(dirpath, d, skip_files_re))

doesn't produce any changes on the list of directories dirnames.

gcloud is of version 183 and python extension was updated on 19th of December(will edit in the version tomorrow).

Thanks for your bug report. I've filed an internal bug for the team which handles dev_appserver.

Any additional information you can provide would be helpful, including the exact gcloud commands you are running. If you can provide part or all of your app.yaml file, that would also be very helpful.

At some point, I thought I was able to replicate the issue, but when I run it outside of the IDE I noticed that everything works as intended. Apparently so far the user who was facing this issue originally uses the same IDE. I will have to investigate more.

Navigation Menu

Repository navigation

dev_appserver.py doesn't ignore directories indicated in --watcher_ignore_re and skip_files #122

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	def ignore_dir(dirpath, dirname, skip_files_re):
	"""Report whether a directory should not be watched."""
	return (dirname.startswith(_IGNORED_PREFIX) or
	skip_files_re and skip_files_re.match(os.path.join(dirpath, dirname)))

	def skip_ignored_dirs(dirpath, dirnames, skip_files_re=None):
	"""Skip directories that should not be watched.

	Args:
	dirpath: the prefix of absolute paths to dirnames.
	dirnames: a list of directories. e.g: we have two directories:
	'/tmp/foo/a.txt', '/tmp/foo/b.txt', then:
	dirpath = '/tmp/foo', dirnames = ['a.txt', 'b.txt']
	skip_files_re: a regular_expression, absolute paths matching it are
	skippable.
	"""

	_remove_pred(dirnames, lambda d: ignore_dir(dirpath, d, skip_files_re))

dev_appserver.py doesn't ignore directories indicated in --watcher_ignore_re and skip_files #122

Description

Activity

duggelz commented on Dec 19, 2017

ar-qun commented on Dec 22, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions