mysql does not preserve dependency_info #309

Activity

1. ylil93

   added

   BacklogSomething that needs to eventually be fixedSomething that needs to eventually be fixed

   on May 6, 2019
2. liyanhui1228 commented on May 7, 2019

   

   liyanhui1228

   on May 7, 2019

   Member

   More actions

   Just curious, are we still using datastore in the latest version of the badge server?
3. ylil93 commented on May 7, 2019

   

   ylil93

   on May 7, 2019

   ContributorAuthor

   More actions

   Yes we are.
4. ylil93

   changed the title [-]Datastore does not preserve dependency_info[/-] [+]mysql does not preserve dependency_info[/+] on May 7, 2019
5. liyanhui1228 commented on May 7, 2019

   

   liyanhui1228

   on May 7, 2019

   Member

   More actions

   Per offline discussion, dependency_info is stored in the release_time_for_dependencies table in our MySQL database. And the issue here is that the save_compatibility_statuses function in compatibility_store is writing data to all the three tables we have in MySQL, thus it required dependency_info in the CompatibilityResult passed in to that function. But when writing tests, in some cases the CompatibilityResult doesn't contain the dependency_info, which makes the read and write to MySQL looks inconsistent.

   A possible improvement could be restructure the save_compatibility_statuses function to split to three sub methods that writes to the three different tables.
6. ylil93 commented on May 7, 2019

   

   ylil93

   on May 7, 2019

   Last edited by ylil93

   ContributorAuthor

   More actions

   Thanks for the explanation! Leaving this issue open until documentation/improvements are added to the project.