Repository navigation
fix(users): declare userId path param on update-user and delete-user - #356
ravihighlevel wants to merge 1 commit into
Conversation
PUT and DELETE /users/{userId} used the {userId} placeholder without a
matching in: path parameter, in both the v2 and v3 specs. Copy the
parameter already declared on get-user.
Refs #326
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
⚪️ [INFO] Object Without Required Property
Details:
OpenAPI v3 specification objects lack required fields defined by the standard,
causing schema validation failures and potential client integration issues.
Missing required properties prevent proper API documentation parsing and code
generation. Include all mandatory fields as specified in the OpenAPI 3.0
specification.
Recommendation:
tags has all required fields
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Object Without Required Property
Details:
OpenAPI v3 specification objects lack required fields defined by the standard,
causing schema validation failures and potential client integration issues.
Missing required properties prevent proper API documentation parsing and code
generation. Include all mandatory fields as specified in the OpenAPI 3.0
specification.
Recommendation:
tags has all required fields
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Object Without Required Property
Details:
OpenAPI v3 specification objects lack required fields defined by the standard,
causing schema validation failures and potential client integration issues.
Missing required properties prevent proper API documentation parsing and code
generation. Include all mandatory fields as specified in the OpenAPI 3.0
specification.
Recommendation:
password has all required fields
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Object Without Required Property
Details:
OpenAPI v3 specification objects lack required fields defined by the standard,
causing schema validation failures and potential client integration issues.
Missing required properties prevent proper API documentation parsing and code
generation. Include all mandatory fields as specified in the OpenAPI 3.0
specification.
Recommendation:
password has all required fields
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Object Without Required Property
Details:
OpenAPI v3 specification objects lack required fields defined by the standard,
causing schema validation failures and potential client integration issues.
Missing required properties prevent proper API documentation parsing and code
generation. Include all mandatory fields as specified in the OpenAPI 3.0
specification.
Recommendation:
tags has all required fields
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Object Without Required Property
Details:
OpenAPI v3 specification objects lack required fields defined by the standard,
causing schema validation failures and potential client integration issues.
Missing required properties prevent proper API documentation parsing and code
generation. Include all mandatory fields as specified in the OpenAPI 3.0
specification.
Recommendation:
tags has all required fields
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Object Without Required Property
Details:
OpenAPI v3 specification objects lack required fields defined by the standard,
causing schema validation failures and potential client integration issues.
Missing required properties prevent proper API documentation parsing and code
generation. Include all mandatory fields as specified in the OpenAPI 3.0
specification.
Recommendation:
tags has all required fields
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Object Without Required Property
Details:
OpenAPI v3 specification objects lack required fields defined by the standard,
causing schema validation failures and potential client integration issues.
Missing required properties prevent proper API documentation parsing and code
generation. Include all mandatory fields as specified in the OpenAPI 3.0
specification.
Recommendation:
tags has all required fields
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Object Without Required Property
Details:
OpenAPI v3 specification objects lack required fields defined by the standard,
causing schema validation failures and potential client integration issues.
Missing required properties prevent proper API documentation parsing and code
generation. Include all mandatory fields as specified in the OpenAPI 3.0
specification.
Recommendation:
tags has all required fields
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Security Requirement Object With Wrong Scopes
Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.
Recommendation:
'security.Agency-Access' has no scopes defined for security scheme of type 'http'
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Security Requirement Object With Wrong Scopes
Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.
Recommendation:
'security.Location-Access' has no scopes defined for security scheme of type
'http'
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Security Requirement Object With Wrong Scopes
Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.
Recommendation:
'security.Agency-Access' has no scopes defined for security scheme of type 'http'
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Security Requirement Object With Wrong Scopes
Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.
Recommendation:
'security.Agency-Access' has no scopes defined for security scheme of type 'http'
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Security Requirement Object With Wrong Scopes
Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.
Recommendation:
'security.Location-Access' has no scopes defined for security scheme of type
'http'
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Security Requirement Object With Wrong Scopes
Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.
Recommendation:
'security.Location-Access' has no scopes defined for security scheme of type
'http'
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Security Requirement Object With Wrong Scopes
Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.
Recommendation:
'security.Agency-Access' has no scopes defined for security scheme of type 'http'
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Security Requirement Object With Wrong Scopes
Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.
Recommendation:
'security.Agency-Access' has no scopes defined for security scheme of type 'http'
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Security Requirement Object With Wrong Scopes
Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.
Recommendation:
'security.Location-Access' has no scopes defined for security scheme of type
'http'
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Security Requirement Object With Wrong Scopes
Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.
Recommendation:
'security.Location-Access' has no scopes defined for security scheme of type
'http'
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
⚪️ [INFO] Security Requirement Object With Wrong Scopes
Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.
Recommendation:
'security.Agency-Access' has no scopes defined for security scheme of type 'http'
💡 Reply
/orca fixto have Orca suggest an AI-generated fix for this finding.
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
🛡️ The following IaC misconfigurations have been detected
| NAME | FILE | ||
|---|---|---|---|
| Security Requirement Object With Wrong Scopes | apps/users.json | View in code | |
| Security Requirement Object With Wrong Scopes | apps/users.json | View in code | |
| Security Requirement Object With Wrong Scopes | apps/users.json | View in code | |
| Security Requirement Object With Wrong Scopes | apps/users.json | View in code | |
| Security Requirement Object With Wrong Scopes | apps/users.json | View in code | |
| Security Requirement Object With Wrong Scopes | apps/users.json | View in code | |
| Security Requirement Object With Wrong Scopes | apps/users.json | View in code | |
| Security Requirement Object With Wrong Scopes | apps/users.json | View in code | |
| Security Requirement Object With Wrong Scopes | apps/users.json | View in code | |
| Security Requirement Object With Wrong Scopes | apps/users.json | View in code | |
| Security Requirement Object With Wrong Scopes | apps/users.json | View in code | |
| Security Requirement Object With Wrong Scopes | apps/users.json | View in code | |
| Template Path With No Corresponding Path Parameter | apps/users.json | View in code | |
| Template Path With No Corresponding Path Parameter | apps/users.json | View in code | |
| Template Path With No Corresponding Path Parameter | apps/users.json | View in code | |
| Unknown Property | apps/users.json | View in code | |
| Unknown Property | apps/users.json | View in code | |
| Unknown Property | apps/users.json | View in code | |
| Unknown Property | apps/users.json | View in code | |
| Unknown Property | apps/users.json | View in code | |
| Security Requirement Object With Wrong Scopes | ...pps/v3/users-v3.json | View in code | |
| Security Requirement Object With Wrong Scopes | ...pps/v3/users-v3.json | View in code | |
| Security Requirement Object With Wrong Scopes | ...pps/v3/users-v3.json | View in code | |
| Security Requirement Object With Wrong Scopes | ...pps/v3/users-v3.json | View in code | |
| Security Requirement Object With Wrong Scopes | ...pps/v3/users-v3.json | View in code | |
| ... | ... | ... | ... |
Quality Gate Results
|
Summary
In both
apps/users.jsonandapps/v3/users-v3.json,PUTandDELETE /users/{userId}use the{userId}placeholder but don't declare a matchingin: pathparameter. Code generators then build a call that needs an argument the input schema doesn't contain. This PR copies theuserIdparameter thatget-useralready declares toupdate-useranddelete-user, in both files.Refs #326. This covers only the users part of that issue; the other operations belong to other teams.
Source of truth
The same fix is already in the
usersservice's spec in marketplace-backend (docs/public/users/users.jsonandusers-v3.json). It hasn't reached this repo because the automated sync is failing. This PR publishes theuserIdfix by hand; the next working sync will overwrite these files with the full upstream spec.Verification
apps/**/*.json, no longer reports anything for users. Before this change it reported 4 (2 per file).🤖 Generated with Claude Code