Skip to content

fix(users): declare userId path param on update-user and delete-user - #356

Open
ravihighlevel wants to merge 1 commit into
mainfrom
fix/users-userid-path-param
Open

ravihighlevel wants to merge 1 commit into
mainfrom
fix/users-userid-path-param

Conversation

@ravihighlevel

Copy link
Copy Markdown

Summary

In both apps/users.json and apps/v3/users-v3.json, PUT and DELETE /users/{userId} use the {userId} placeholder but don't declare a matching in: path parameter. Code generators then build a call that needs an argument the input schema doesn't contain. This PR copies the userId parameter that get-user already declares to update-user and delete-user, in both files.

Refs #326. This covers only the users part of that issue; the other operations belong to other teams.

Source of truth

The same fix is already in the users service's spec in marketplace-backend (docs/public/users/users.json and users-v3.json). It hasn't reached this repo because the automated sync is failing. This PR publishes the userId fix by hand; the next working sync will overwrite these files with the full upstream spec.

Verification

🤖 Generated with Claude Code

PUT and DELETE /users/{userId} used the {userId} placeholder without a
matching in: path parameter, in both the v2 and v3 specs. Copy the
parameter already declared on get-user.

Refs #326

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment thread apps/v3/users-v3.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/v3/users-v3.json:536

⚪️ [INFO] Object Without Required Property

Details:
OpenAPI v3 specification objects lack required fields defined by the standard,
causing schema validation failures and potential client integration issues.
Missing required properties prevent proper API documentation parsing and code
generation. Include all mandatory fields as specified in the OpenAPI 3.0
specification.

Recommendation:
tags has all required fields

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/v3/users-v3.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/v3/users-v3.json:448

⚪️ [INFO] Object Without Required Property

Details:
OpenAPI v3 specification objects lack required fields defined by the standard,
causing schema validation failures and potential client integration issues.
Missing required properties prevent proper API documentation parsing and code
generation. Include all mandatory fields as specified in the OpenAPI 3.0
specification.

Recommendation:
tags has all required fields

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/v3/users-v3.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/v3/users-v3.json:2192

⚪️ [INFO] Object Without Required Property

Details:
OpenAPI v3 specification objects lack required fields defined by the standard,
causing schema validation failures and potential client integration issues.
Missing required properties prevent proper API documentation parsing and code
generation. Include all mandatory fields as specified in the OpenAPI 3.0
specification.

Recommendation:
password has all required fields

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/v3/users-v3.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/v3/users-v3.json:1657

⚪️ [INFO] Object Without Required Property

Details:
OpenAPI v3 specification objects lack required fields defined by the standard,
causing schema validation failures and potential client integration issues.
Missing required properties prevent proper API documentation parsing and code
generation. Include all mandatory fields as specified in the OpenAPI 3.0
specification.

Recommendation:
password has all required fields

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/v3/users-v3.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/v3/users-v3.json:2712

⚪️ [INFO] Object Without Required Property

Details:
OpenAPI v3 specification objects lack required fields defined by the standard,
causing schema validation failures and potential client integration issues.
Missing required properties prevent proper API documentation parsing and code
generation. Include all mandatory fields as specified in the OpenAPI 3.0
specification.

Recommendation:
tags has all required fields

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/v3/users-v3.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/v3/users-v3.json:625

⚪️ [INFO] Object Without Required Property

Details:
OpenAPI v3 specification objects lack required fields defined by the standard,
causing schema validation failures and potential client integration issues.
Missing required properties prevent proper API documentation parsing and code
generation. Include all mandatory fields as specified in the OpenAPI 3.0
specification.

Recommendation:
tags has all required fields

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/v3/users-v3.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/v3/users-v3.json:178

⚪️ [INFO] Object Without Required Property

Details:
OpenAPI v3 specification objects lack required fields defined by the standard,
causing schema validation failures and potential client integration issues.
Missing required properties prevent proper API documentation parsing and code
generation. Include all mandatory fields as specified in the OpenAPI 3.0
specification.

Recommendation:
tags has all required fields

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/v3/users-v3.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/v3/users-v3.json:351

⚪️ [INFO] Object Without Required Property

Details:
OpenAPI v3 specification objects lack required fields defined by the standard,
causing schema validation failures and potential client integration issues.
Missing required properties prevent proper API documentation parsing and code
generation. Include all mandatory fields as specified in the OpenAPI 3.0
specification.

Recommendation:
tags has all required fields

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/v3/users-v3.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/v3/users-v3.json:267

⚪️ [INFO] Object Without Required Property

Details:
OpenAPI v3 specification objects lack required fields defined by the standard,
causing schema validation failures and potential client integration issues.
Missing required properties prevent proper API documentation parsing and code
generation. Include all mandatory fields as specified in the OpenAPI 3.0
specification.

Recommendation:
tags has all required fields

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/v3/users-v3.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/v3/users-v3.json:541

⚪️ [INFO] Security Requirement Object With Wrong Scopes

Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.

Recommendation:
'security.Agency-Access' has no scopes defined for security scheme of type 'http'

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/users.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/users.json:185

⚪️ [INFO] Security Requirement Object With Wrong Scopes

Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.

Recommendation:
'security.Location-Access' has no scopes defined for security scheme of type
'http'

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/users.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/users.json:268

⚪️ [INFO] Security Requirement Object With Wrong Scopes

Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.

Recommendation:
'security.Agency-Access' has no scopes defined for security scheme of type 'http'

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/users.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/users.json:692

⚪️ [INFO] Security Requirement Object With Wrong Scopes

Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.

Recommendation:
'security.Agency-Access' has no scopes defined for security scheme of type 'http'

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/v3/users-v3.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/v3/users-v3.json:361

⚪️ [INFO] Security Requirement Object With Wrong Scopes

Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.

Recommendation:
'security.Location-Access' has no scopes defined for security scheme of type
'http'

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/v3/users-v3.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/v3/users-v3.json:458

⚪️ [INFO] Security Requirement Object With Wrong Scopes

Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.

Recommendation:
'security.Location-Access' has no scopes defined for security scheme of type
'http'

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/v3/users-v3.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/v3/users-v3.json:183

⚪️ [INFO] Security Requirement Object With Wrong Scopes

Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.

Recommendation:
'security.Agency-Access' has no scopes defined for security scheme of type 'http'

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/users.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/users.json:533

⚪️ [INFO] Security Requirement Object With Wrong Scopes

Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.

Recommendation:
'security.Agency-Access' has no scopes defined for security scheme of type 'http'

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/users.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/users.json:538

⚪️ [INFO] Security Requirement Object With Wrong Scopes

Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.

Recommendation:
'security.Location-Access' has no scopes defined for security scheme of type
'http'

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/users.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/users.json:356

⚪️ [INFO] Security Requirement Object With Wrong Scopes

Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.

Recommendation:
'security.Location-Access' has no scopes defined for security scheme of type
'http'

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

Comment thread apps/users.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/users.json:180

⚪️ [INFO] Security Requirement Object With Wrong Scopes

Details:
OpenAPI security requirements define scopes for authentication schemes, but only
OAuth2 and OpenID Connect support scope-based authorization. Specifying scopes
for API Key or HTTP authentication types creates invalid configurations that fail
validation. Remove scopes from security requirements using authentication types
that do not support them.

Recommendation:
'security.Agency-Access' has no scopes defined for security scheme of type 'http'

💡 Reply /orca fix to have Orca suggest an AI-generated fix for this finding.

@orca-security-us orca-security-us Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 50 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca
🛡️ The following IaC misconfigurations have been detected
NAME FILE
info Security Requirement Object With Wrong Scopes apps/users.json View in code
info Security Requirement Object With Wrong Scopes apps/users.json View in code
info Security Requirement Object With Wrong Scopes apps/users.json View in code
info Security Requirement Object With Wrong Scopes apps/users.json View in code
info Security Requirement Object With Wrong Scopes apps/users.json View in code
info Security Requirement Object With Wrong Scopes apps/users.json View in code
info Security Requirement Object With Wrong Scopes apps/users.json View in code
info Security Requirement Object With Wrong Scopes apps/users.json View in code
info Security Requirement Object With Wrong Scopes apps/users.json View in code
info Security Requirement Object With Wrong Scopes apps/users.json View in code
info Security Requirement Object With Wrong Scopes apps/users.json View in code
info Security Requirement Object With Wrong Scopes apps/users.json View in code
info Template Path With No Corresponding Path Parameter apps/users.json View in code
info Template Path With No Corresponding Path Parameter apps/users.json View in code
info Template Path With No Corresponding Path Parameter apps/users.json View in code
info Unknown Property apps/users.json View in code
info Unknown Property apps/users.json View in code
info Unknown Property apps/users.json View in code
info Unknown Property apps/users.json View in code
info Unknown Property apps/users.json View in code
info Security Requirement Object With Wrong Scopes ...pps/v3/users-v3.json View in code
info Security Requirement Object With Wrong Scopes ...pps/v3/users-v3.json View in code
info Security Requirement Object With Wrong Scopes ...pps/v3/users-v3.json View in code
info Security Requirement Object With Wrong Scopes ...pps/v3/users-v3.json View in code
info Security Requirement Object With Wrong Scopes ...pps/v3/users-v3.json View in code
... ... ... ...

@code-quality-gates

Copy link
Copy Markdown

Quality Gate Results

⚠️ 1 Warning(s) — non-blocking, please review
✅ 6 Passed

⚠️ Warnings (non-blocking — worth reviewing)

  • dependency_license_check (1 item) — detailed results (inline comments only on changed lines) · 📖 docs

🔍 View detailed quality gate results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants