Repository navigation
[CHA-0] test: fix image fixture 404 and hide/show race - #177
Merged
Merged
Conversation
The favicon URL used by testChannelSendAndDeleteImage now returns 404, so upload a local PNG instead. The backend unhides a hidden channel in a background task after a new message, so testChannelHideShow polls for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nijeesh-stream
requested review from
JimmyPettersson85 and
yaziine
as code owners
October 15, 2026 02:09
nijeesh-stream
enabled auto-merge (squash)
October 15, 2026 09:39
JimmyPettersson85
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
The required
🧪 Test & lint (8.1)and(8.2)checks fail on every PR, including docs-only #175, for two reasons that have nothing to do with the SDK code. This PR fixes both tests. Risk is negligible: tests only.Ticket
Summary
testChannelSendAndDeleteImage:https://getstream.io/images/icons/favicon-32x32.pngnow returns 404, sofile_get_contentserrors. The test now uploads a small local PNG (tests/integration/fixtures/logo.png, 32x32), so it no longer depends on a website asset.testChannelHideShow: fails withFailed asserting that 1 is identical to 0on the last assertion. When a message is sent, the backend unhides the channel for other members in a background task (ShowChannelForAllUsersAsync), not inline. The test asserted right aftersendMessage. It now pollsqueryChannelsfor up to 10s (the pattern the file already uses for tasks).stream-chat-pythonhas the same hide/show race intest_channel_hide_show.Checklist
php-cs-fixer --dry-runclean,php -lclean./docs) has been updated (n/a)🤖 Generated with Claude Code