Repository navigation
docs(adr): tidy ADR-0010's detection consequence after two edits landed - #300
Merged
Merged
Conversation
The bullet was edited by #126 while #295 was rewriting the verification section below it. Both merged cleanly and neither changed a fact, but the bullet came out of it the longest in Consequences by half again, and carrying a sentence that reads as a typo: "two dns modules on the blackbox-exporter #91 landed" is missing its "that". Three fixes, no new claims. The #91 clause goes -- which exporter the probes run on is not what this consequence is about. The blocker is named in full: the bullet said the targets wait on #102, and they also wait on a forwarder that can fail, which is the finding the verification section directly below records and the thing this decision turns on. And the reference to that section now says "asks for" without restating the test it describes two screens down. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Prose only, in one bullet of ADR-0010's Consequences. No fact changes, no config touched.
Why
#126 and #295 edited ADR-0010 within the same hour — one the detection consequence, one the verification section below it. Git merged both without a conflict and neither changed a measured fact, but nobody read the result end to end. Three things came out of it:
dnsmodules on the blackbox-exporter Probe the services this was filed for, and probe TLS expiry #91 landed" is missing its "that". The clause is now gone rather than repaired — which exporter the probes run on is not what this consequence is about, and Probe the services this was filed for, and probe TLS expiry #91 is already credited where the exporter is described.Blast radius
None. One markdown file.
secrets/*.sops.yamlVerification
scripts/lint.shandscripts/check_docs.pyboth pass. Diff is 11 lines removed, 8 added, all inside one bullet.make validatepasses🤖 Generated with Claude Code