Repository navigation
Classes must be declared abstract or final - #37
Open
qberlemont wants to merge 8 commits into
Open
qberlemont wants to merge 8 commits into
qberlemont wants to merge 8 commits into
Conversation
qberlemont
requested review from
FloBGeo,
Kleinast,
anthonydessalles,
bboivin-geolid and
janvierm
March 26, 2021 15:48
qberlemont
changed the title
Contributor
|
Du coup les tests passent pas vu que les class de tests sont pas en final. |
Author
oui c'est en WIP |
qberlemont
changed the title
Contributor
|
Ah mais du coup y avais bien une configuration phpcs en fait ^^ |
qberlemont
changed the title
qberlemont
changed the title
janvierm
approved these changes
Apr 12, 2021
Kleinast
approved these changes
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All classes must be final, except abstract ones and Doctrine entities.
https://ocramius.github.io/blog/when-to-declare-classes-final/