Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The sample cannot compile against the shipped header, and adapter selection and incremental packaging need correction.
3 open issues
What changed in this PR
This PR expands the installed PresentMon SDK with a metrics reference and a minimal sample for polling displayed FPS and GPU utilization.
Changes:
- Adds the sample, its CMake build configuration, and build/run instructions.
- Packages
metrics.csvand the sample sources with the optional SDK feature. - Passes the new payload paths through CMake and MSBuild to WiX.
| File | Description |
|---|---|
| README-Service.md | Documents SDK additions and sample usage. |
| IntelPresentMon/Samples/main.c | Adds FPS and GPU utilization polling. |
| IntelPresentMon/Samples/CMakeLists.txt | Configures sample linking and loader DLL copying. |
| IntelPresentMon/PmonCMakePackaging.wixproj.props | Exposes new SDK payload paths to WiX. |
| IntelPresentMon/PMInstaller/PresentMon.wxs | Installs the metrics reference and sample files. |
| cmake/PresentMonPackaging.cmake | Supplies SDK payload paths to MSBuild. |
Review effort: Balanced
Ship metrics.csv and a minimal C FPS/GPU sample (with CMake) in the SDK install, and make PresentMonAPI.h plain C so the SDK is easier for people and LLMs to read and use.
gvinals
force-pushed
the
gvinals/sdk_improvements
branch
from
October 23, 2026 22:24
153474e to
f82f9cb
Compare
gvinals
marked this pull request as ready for review
October 23, 2026 22:25
Comment on lines
+85
to
+90
| char* end = NULL; | ||
| unsigned long pidLong = strtoul(argv[1], &end, 10); | ||
| if (end == argv[1] || *end != '\0' || pidLong == 0ul || pidLong > 0xfffffffful) { | ||
| fprintf(stderr, "Invalid process id: %s\n", argv[1]); | ||
| return 1; | ||
| } |
Comment on lines
+177
to
+178
| if (!GetExitCodeProcess(hProcess, &processExitCode) || | ||
| processExitCode != STILL_ACTIVE) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve PresentMon SDK discoverability and C usability
Ship metrics.csv and a minimal C FPS/GPU sample (with CMake) in the SDK
install, and make PresentMonAPI.h plain C so the SDK is easier for people
and LLMs to read and use.